[tests-only] Smaller fixes for LDAP based tests on oCIS #39914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OUs for group where mixed up. This went unnoticed since the reva configuration was using the top of the LDAP tree as the search base for users and groups.
|
Kudos, SonarCloud Quality Gate passed! |
phil-davis
approved these changes
Mar 23, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The OUs for group where mixed up. This went unnoticed since the reva configuration was using the top of the LDAP tree as the search base for users and groups.
This also includes a small change for creating LDAP user when testing against oCIS. Current the default configuration for oCIS requires the mail attribute to be present on the user object. We make sure to add it. (Similar to what is done for the non-LDAP case)
Motivation and Context
Being able to run the LDAP based test-suite against ocis