Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Adds API tests for meta endpoint PROPFIND with oc:meta-path-for-user property #40042

Merged
merged 2 commits into from
May 20, 2022
Merged

[tests-only][full-ci]Adds API tests for meta endpoint PROPFIND with oc:meta-path-for-user property #40042

merged 2 commits into from
May 20, 2022

Conversation

amrita-shrestha
Copy link
Contributor

Description

Adds API tests for meta endpoint PROPFIND with oc:meta-path-for-user property

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@amrita-shrestha amrita-shrestha self-assigned this May 3, 2022
@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-meta-api branch from 81c053c to d2c311d Compare May 18, 2022 07:13
@SwikritiT SwikritiT force-pushed the add-tests-for-meta-api branch from 35b3eee to 8179f8e Compare May 19, 2022 05:36
@SwikritiT SwikritiT marked this pull request as ready for review May 19, 2022 05:36
kiranparajuli589
kiranparajuli589 reviewed May 19, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 but ci looks sad

@SwikritiT SwikritiT force-pushed the add-tests-for-meta-api branch 2 times, most recently from 97e8eea to 2c3e4e9 Compare May 20, 2022 04:10
@SwikritiT SwikritiT force-pushed the add-tests-for-meta-api branch from 2c3e4e9 to 078398d Compare May 20, 2022 04:40
@SwikritiT SwikritiT requested review from SagarGi and saw-jan May 20, 2022 04:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SagarGi
SagarGi reviewed May 20, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

saw-jan
saw-jan reviewed May 20, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@individual-it individual-it merged commit fe24adf into master May 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-tests-for-meta-api branch May 20, 2022 06:33
@SwikritiT SwikritiT mentioned this pull request May 23, 2022
Closed
@kiranparajuli589 kiranparajuli589 mentioned this pull request May 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@SagarGi SagarGi SagarGi left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@individual-it individual-it individual-it approved these changes

@sushmita56 sushmita56 Awaiting requested review from sushmita56

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amrita-shrestha @individual-it @kiranparajuli589 @SwikritiT @SagarGi @saw-jan