Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Revert trashbin href test code #40050

Merged
merged 2 commits into from
May 5, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented May 4, 2022

Description

  1. revert the temporary trashbin test work-around that was added in PR [tests-only] full-ci] Fix path calculation in listTrashbinFolderCollection #40037

  2. Add checks to listTrashbinFolderCollection code to throw an exception when an obviously unexpected trashbin href is detected in a response. That will help detect problems earlier, and avoid the potential to have an infinite recursion )wh.en drilling down in the trashbin (if a system-under-test gives href values that point back to the top..

Note: the reva implementation of trashbin PROPFIND responses was fixed in cs3org/reva#2821 and pulled into oCIS in owncloud/ocis#3681 - so all implementations (oC10, oCIS and reva) will work the same, and test the same.

How Has This Been Tested?

CI of cs3org/reva#2823

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis marked this pull request as ready for review May 4, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants