Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Adjust test for limit search assertion #40214

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Jul 19, 2022

Description

This PR adjust the search limit which fails on assertion for the failure on ocis.
Previously while testing on ocis, the test code only check for the non-empty $entryNameToSearch. But incase of null $entryNameToSearch for new endpoint whole url was pushed to array instead of only the files|folders names causing the test to fail.

Related Issue

owncloud/ocis#4017

Motivation and Context

How Has This Been Tested?

  • CI
  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi force-pushed the adjustCodeForSearchLimitAssertion branch from b2705b5 to 6ece18b Compare July 19, 2022 10:43
@SagarGi SagarGi requested a review from SwikritiT July 19, 2022 10:49
@SagarGi SagarGi marked this pull request as ready for review July 19, 2022 10:49
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 854ee4b into master Jul 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the adjustCodeForSearchLimitAssertion branch July 20, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants