-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Refactor code to reuse code in ocis
#40328
Conversation
NOTE: We can do like this instead of creating extra helper function to reuse then code from ocis. If feasible then we can go ahead and refactor where code duplication has been done. |
ocis
ocis
ocis
ocis
4114692
to
bd5d25a
Compare
bd5d25a
to
92bfaf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK - let's merge this and we can see what the refactoring of oCIS local API tests looks like. We can adjust again if we need to...
Description
This PR adds some code adjustment (in core) so that the code can be reused in ocis (If any new implementation is done). Since as of now we are duplicating the same code in core as well as in ocis.
We have a
favourite.feature
feature in ocis where we have been duplicating code so for reference i have tried to reduce the code inocis
for the feature so that it uses code (resource) already in core (for reducing code duplication). Follow this PR owncloud/ocis#4492Related Issue
No related Issue So far since this is a sample PR (After approval) a separate issue is made for refactoring and code reuse from core for ocis implementation.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: