Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Refactor code to reuse code in ocis #40328

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Sep 2, 2022

Description

This PR adds some code adjustment (in core) so that the code can be reused in ocis (If any new implementation is done). Since as of now we are duplicating the same code in core as well as in ocis.

We have a favourite.feature feature in ocis where we have been duplicating code so for reference i have tried to reduce the code in ocis for the feature so that it uses code (resource) already in core (for reducing code duplication). Follow this PR owncloud/ocis#4492

Related Issue

No related Issue So far since this is a sample PR (After approval) a separate issue is made for refactoring and code reuse from core for ocis implementation.

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi marked this pull request as ready for review September 2, 2022 03:54
@SagarGi SagarGi marked this pull request as draft September 2, 2022 03:55
@SagarGi SagarGi self-assigned this Sep 2, 2022
@SagarGi SagarGi added the QA:team label Sep 2, 2022
@SagarGi SagarGi marked this pull request as ready for review September 2, 2022 06:23
@SagarGi
Copy link
Member Author

SagarGi commented Sep 2, 2022

NOTE: We can do like this instead of creating extra helper function to reuse then code from ocis. If feasible then we can go ahead and refactor where code duplication has been done.

@SagarGi SagarGi changed the title [donot-merge][tests-only][full-ci]Refactor for Code without wrapper(Helper) to reuse code in ocis [tests-only][full-ci]Refactor for Code without wrapper(Helper) to reuse code in ocis Sep 2, 2022
@SagarGi SagarGi changed the title [tests-only][full-ci]Refactor for Code without wrapper(Helper) to reuse code in ocis [tests-only][full-ci]Refactor code to reuse code in ocis Sep 2, 2022
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK - let's merge this and we can see what the refactoring of oCIS local API tests looks like. We can adjust again if we need to...

tests/TestHelpers/WebDavHelper.php Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants