fix: \OCP\IDBConnection return declarations #41115
Closed
+11
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
force-pushed
the
fix/dbconnection-return
branch
from
21c1849
to
58ac4fd
Compare
|
Kudos, SonarCloud Quality Gate passed! |
phil-davis
reviewed
Nov 22, 2023
Comment on lines
-151
to
-158
| /** | ||
| * Prepares an SQL statement. | ||
| * | ||
| * @param string $statement The SQL statement to prepare. | ||
| * @param int $limit | ||
| * @param int $offset | ||
| * @return \Doctrine\DBAL\Driver\Statement The prepared statement. | ||
| */ |
There was a problem hiding this comment.
why delete all the PHPdoc?
There was a problem hiding this comment.
Will replace them with real type declarations.
|
cleaning up - I think this is no longer of anybody's interest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: