-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upload abortion detection only for PUT #5125
Conversation
Test failed. |
:ooops: |
@@ -53,6 +53,11 @@ public function initialize(Sabre_DAV_Server $server) { | |||
*/ | |||
public function verifyContentLength($filePath, Sabre_DAV_INode $node = null) { | |||
|
|||
// we should only react on PUT - e.h. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.h.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\o/
e.g. LOCK would break with this approach
@@ -53,6 +53,12 @@ public function initialize(Sabre_DAV_Server $server) { | |||
*/ | |||
public function verifyContentLength($filePath, Sabre_DAV_INode $node = null) { | |||
|
|||
// we should only react on PUT which is used for upload | |||
// e.g. with LOCK this will not work, but LOCK uses createFile() as well | |||
if ($this->server->httpRequest->getMethod() !== 'PUT' ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't like the space after 'PUT'. I don't know why people keep doing this.
👍 |
Test passed. |
Test passed. |
👍 |
upload abortion detection only for PUT
e.g. LOCK would break with this approach
fixes #5122