Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved persistent cookies #8

Closed
wants to merge 2 commits into from
Closed

improved persistent cookies #8

wants to merge 2 commits into from

Conversation

visit1985
Copy link

Each user can have more than one persistent login token which enables persistent sessions in multiple browsers.

Tokens and cookies are regenerated on each login.

Tokens will be deleted if they aren't used for 90 days.

I've modified token generation from time to random number to make it more secure.

Regards,
Michael

@LukasReschke
Copy link
Member

Thanks!

Just as an information for you: We're currently in the hard feature freeze for 4.5 which will last until the release of 4.5. This means that we're currently not allowed to commit new features. I'm sure someone will take a look at it, after the release of 4.5 :-)

Michael Göhler added 2 commits October 6, 2012 21:58
added methods valueExists(), setMultiValue(), deleteValues() to preferences lib
added new column "created" to preferences table
raised version number by one to trigger database schema update
modified token generation from time to random number
from now on cookies are regenerated on each login
each user can have more than one persistent login token
persistent login cookies will be deleted after 90 days
switched from mt_rand() to internal method OC_Util::generate_random_bytes()
@DeepDiver1975
Copy link
Member

@visit1985: I'll close this merge request and kindly ask you to resubmit this pull request on basis of the current master.
Something was changed during the past month which prevents automatic merge.

THX a lot

@ghost ghost mentioned this pull request Jul 23, 2014
bhawanaprasain pushed a commit to JankariTech/core that referenced this pull request Apr 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants