Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for running GUI tests #62

Merged
merged 8 commits into from
Jun 25, 2021
Merged

Added docs for running GUI tests #62

merged 8 commits into from
Jun 25, 2021

Conversation

swoichha
Copy link
Contributor

Description

This PR adds document on how to set up client and squish locally, and run GUI tests.

Related Issue

owncloud/client#8705

@swoichha swoichha added the documentation Improvements or additions to documentation label Jun 22, 2021
@swoichha swoichha self-assigned this Jun 22, 2021
@mmattel mmattel self-requested a review June 22, 2021 16:44
@mmattel mmattel requested a review from EParzefall June 22, 2021 18:14
@mmattel
Copy link
Contributor

mmattel commented Jun 22, 2021

@EParzefall could you please do a language check?

Copy link
Contributor

@EParzefall EParzefall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modules/ROOT/pages/appendices/guitest.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/appendices/guitest.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/appendices/guitest.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/appendices/guitest.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/appendices/guitest.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/appendices/guitest.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/appendices/guitest.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/appendices/guitest.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/appendices/guitest.adoc Outdated Show resolved Hide resolved
swoichha and others added 2 commits June 23, 2021 17:42
Co-authored-by: Phil Davis <phil@jankaritech.com>
@swoichha swoichha marked this pull request as ready for review June 24, 2021 10:25
@mmattel
Copy link
Contributor

mmattel commented Jun 24, 2021

@swoichha
do you plan more changes (because of additional language checks...)
do we need backporting to 2.8 and 2.7 (else it will only go to master and any upcoming 2.9 release)

@swoichha
Copy link
Contributor Author

swoichha commented Jun 25, 2021

@swoichha
do you plan more changes (because of additional language checks...)

@mmattel There are no changes to be added expect the language check. @EParzefall can you review the language once again?

do we need backporting to 2.8 and 2.7 (else it will only go to master and any upcoming 2.9 release)

Yes we need backporting to 2.8 and 2.7 as well.

Copy link
Contributor

@EParzefall EParzefall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor fixes

modules/ROOT/pages/appendices/guitest.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/appendices/guitest.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/appendices/guitest.adoc Outdated Show resolved Hide resolved
mmattel and others added 3 commits June 25, 2021 10:54
Co-authored-by: Edith Parzefall <edith_parzefall@gmx.de>
Co-authored-by: Edith Parzefall <edith_parzefall@gmx.de>
Co-authored-by: Edith Parzefall <edith_parzefall@gmx.de>
@mmattel mmattel merged commit 8a2ef2c into master Jun 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the doc-run-gui-test branch June 25, 2021 08:56
mmattel added a commit that referenced this pull request Jun 25, 2021
mmattel added a commit that referenced this pull request Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants