chore(deps): bump del from 6.1.1 to 8.0.0 #836
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [del](https://github.com/sindresorhus/del) from 6.1.1 to 8.0.0. - [Release notes](https://github.com/sindresorhus/del/releases) - [Commits](sindresorhus/del@v6.1.1...v8.0.0) --- updated-dependencies: - dependency-name: del dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
phil-davis
force-pushed
the
dependabot/npm_and_yarn/del-8.0.0
branch
2 times, most recently
from
6bd5c28
to
d76b301
Compare
phil-davis
force-pushed
the
dependabot/npm_and_yarn/del-8.0.0
branch
from
d76b301
to
93abba9
Compare
| @@ -1,9 +1,10 @@ | |||
| "use strict"; | |||
|
|
|||
| import { deleteSync } from 'del'; | |||
There was a problem hiding this comment.
The newer del needs us to use "import" rather than "require".
But "import" only works if this code is a "module" (see the "type": "module" added to package.json)
And some discussion in https://stackoverflow.com/questions/58384179/syntaxerror-cannot-use-import-statement-outside-a-module
But now lint CI complains:
ReferenceError: require is not defined in ES module scope, you can use import instead
The other require() in this file stop working. They would also have to be changed to import statements.
I will leave this code here as a clue to where I got to in a few minutes.
Probably there is some easier solution to make this work, someone can try to find it if this major version upgrade is needed.
|
@mmattel I thought that I might be able to make this work easily, but not so. See comment above. |
|
@phil-davis the issue behind is the (slow) migration from common js (cjs) to esm which use different ways of importing and other stuff. Though dependencies can be setup to function with both, it is not consistently implemented causing issues. After trying some variants to solve this locally and gaining same very basic knowledge about the underlaying issue, I need to ask a "professional" for support if and how this is fixable. For reference, this what I started to try: https://www.npmjs.com/package/esm |
Bumps del from 6.1.1 to 8.0.0.
Release notes
Sourced from del's releases.
Commits
51344d28.0.07778d71Meta tweakse2e5b71Require Node.js 18 and update dependencies (#161)7df79497.1.0f5d31e6AddpathtoonProgressevent (#155)e9b0d71Fix CI9e17de8Documentdotoption (#148)5345ef67.0.0e02a96bMeta tweaks106d7d8Move to ESM (#143)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)