Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate nightly CI cors fails #232

Closed
phil-davis opened this issue Jan 26, 2021 · 2 comments · Fixed by owncloud/core#38345
Closed

Investigate nightly CI cors fails #232

phil-davis opened this issue Jan 26, 2021 · 2 comments · Fixed by owncloud/core#38345
Assignees
Labels

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Jan 26, 2021

https://drone.owncloud.com/owncloud/encryption/1655/50/16

runsh: Total unexpected failed scenarios throughout the test run:
apiAuth/cors.feature:40
apiAuth/cors.feature:41
Feature: CORS headers

  Background:                                                                      # /var/www/owncloud/testrunner/tests/acceptance/features/apiAuth/cors.feature:4
    Given user "Alice" has been created with default attributes and skeleton files # FeatureContext::userHasBeenCreatedWithDefaultAttributes()

  @files_sharing-app-required
  Scenario Outline: CORS headers should be returned when setting CORS domain sending Origin header # /var/www/owncloud/testrunner/tests/acceptance/features/apiAuth/cors.feature:8
    Given using OCS API version "<ocs_api_version>"                                                # FeatureContext::usingOcsApiVersion()
    And user "Alice" has added "https://aphno.badal" to the list of personal CORS domains          # CorsContext::addDomainToPrivateCORSLists()
    When user "Alice" sends HTTP method "GET" to OCS API endpoint "<endpoint>" with headers        # OCSContext::userSendsToOcsApiEndpointWithHeaders()
      | header | value               |
      | Origin | https://aphno.badal |
    Then the OCS status code should be "<ocs-code>"                                                # OCSContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "<http-code>"                                               # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    Then the following headers should be set                                                       # FeatureContext::theFollowingHeadersShouldBeSet()
      | header                        | value                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 |
      | Access-Control-Allow-Headers  | OC-Checksum,OC-Total-Length,OCS-APIREQUEST,X-OC-Mtime,Accept,Authorization,Brief,Content-Length,Content-Range,Content-Type,Date,Depth,Destination,Host,If,If-Match,If-Modified-Since,If-None-Match,If-Range,If-Unmodified-Since,Location,Lock-Token,Overwrite,Prefer,Range,Schedule-Reply,Timeout,User-Agent,X-Expected-Entity-Length,Accept-Language,Access-Control-Request-Method,Access-Control-Allow-Origin,ETag,OC-Autorename,OC-CalDav-Import,OC-Chunked,OC-Etag,OC-FileId,OC-LazyOps,OC-Total-File-Length,Origin,X-Request-ID,X-Requested-With |
      | Access-Control-Expose-Headers | Content-Location,DAV,ETag,Link,Lock-Token,OC-ETag,OC-Checksum,OC-FileId,OC-JobStatus-Location,Vary,Webdav-Location,X-Sabre-Status                                                                                                                                                                                                                                                                                                                                                                                                                     |
      | Access-Control-Allow-Origin   | https://aphno.badal                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   |
      | Access-Control-Allow-Methods  | GET,OPTIONS,POST,PUT,DELETE,MKCOL,PROPFIND,PATCH,PROPPATCH,REPORT                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     |

    Examples:
      | ocs_api_version | endpoint                                         | ocs-code | http-code |
      | 1               | /apps/files_external/api/v1/mounts               | 100      | 200       |
      | 2               | /apps/files_external/api/v1/mounts               | 200      | 200       |
      | 1               | /apps/files_sharing/api/v1/remote_shares         | 100      | 200       |
      | 2               | /apps/files_sharing/api/v1/remote_shares         | 200      | 200       |
      | 1               | /apps/files_sharing/api/v1/remote_shares/pending | 100      | 200       |
      | 2               | /apps/files_sharing/api/v1/remote_shares/pending | 200      | 200       |
      | 1               | /apps/files_sharing/api/v1/shares                | 100      | 200       |
      | 2               | /apps/files_sharing/api/v1/shares                | 200      | 200       |
      | 1               | /privatedata/getattribute                        | 100      | 200       |
      | 2               | /privatedata/getattribute                        | 200      | 200       |
      | 1               | /cloud/apps                                      | 997      | 401       |
      | 2               | /cloud/apps                                      | 997      | 401       |
      | 1               | /cloud/groups                                    | 997      | 401       |
      | 2               | /cloud/groups                                    | 997      | 401       |
      | 1               | /cloud/users                                     | 997      | 401       |
      | 2               | /cloud/users                                     | 997      | 401       |
      | 1               | /config                                          | 100      | 200       |
        Missing expected header 'Access-Control-Allow-Headers' (Exception)
      | 2               | /config                                          | 200      | 200       |
        Missing expected header 'Access-Control-Allow-Headers' (Exception)

Those scenarios were refactored by PR owncloud/core#37272 so they need to be skipped on old oC10.

@phil-davis phil-davis self-assigned this Jan 26, 2021
@phil-davis
Copy link
Contributor Author

phil-davis commented Jan 26, 2021

Also https://drone.owncloud.com/owncloud/encryption/1655/73/16

runsh: Total unexpected failed scenarios throughout the test run:
apiWebdavOperations/downloadFile.feature:60
apiWebdavOperations/downloadFile.feature:61

Those scenarios were changed by PR https://github.com/owncloud/core/pull/38305 so they need to be skipped on old oC10.

@phil-davis
Copy link
Contributor Author

Fixed by core PR owncloud/core#38345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant