Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] skip refactored tests on old oC10 #38345

Merged
merged 1 commit into from
Jan 26, 2021
Merged

[tests-only] skip refactored tests on old oC10 #38345

merged 1 commit into from
Jan 26, 2021

Conversation

phil-davis
Copy link
Contributor

Description

Fixes owncloud/encryption#232

core PRs #37272 and #38305 changed some test scenarios due to issues being fixed. Those test scenarios are no longer valid against older oC10 core versions - so skip them in that case.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Jan 26, 2021
@phil-davis phil-davis mentioned this pull request Jan 26, 2021
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it individual-it merged commit d60a520 into master Jan 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the skip-on-old-oc10-20210126 branch January 26, 2021 07:43
@phil-davis phil-davis mentioned this pull request Jan 28, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

Assignees

@phil-davis phil-davis

Labels
3 - To Review QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate nightly CI cors fails
2 participants
@phil-davis @individual-it