Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Refactor examples table tags related to PRs 38345 and 37272 #38358

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

phil-davis
Copy link
Contributor

Description

PR #37272 fixed a problem, and 2 Scenario Outlines were correctly merged into a single Scenario Outline with a single examples table.

PR #38345 added some skip* tags to that Scenario Outline. We needed to skip a couple of the examples on old oC10 releases, because they will nt pass on those old releases. We had to skip the whole Scenario Outline (all the examples), because Behat/Gherkin did not support multiple example tables with different tags.

Now Behat/Gherkin#117 feature has been released. We can make multiple example tables with different tags on the same Scenario Outline.

This PR implements our first "multiple examples tables".

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis
Copy link
Contributor Author

Note: while doing this PR, I locally tried various combinations of multiple example tables with different tags on each and ran tests locally filtered by tag. The multiple examples tables Gherkin feature works as I expect. The examples in an examples table effective get:

  • any tags on the whole Feature, and
  • any tags on the Scenario Outline, and
  • any tags on the Examples table

@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it individual-it merged commit 7d1c4f6 into master Jan 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the refactor-tags-examples-table branch January 28, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants