Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tags on Examples #117

Closed
stukalin opened this issue Nov 9, 2016 · 5 comments
Closed

Add support for tags on Examples #117

stukalin opened this issue Nov 9, 2016 · 5 comments

Comments

@stukalin
Copy link
Contributor

stukalin commented Nov 9, 2016

According to this https://cucumber.io/docs/reference there should be support for tags on Examples. Currently I've got an error when I add one.

Is it planned to be added? Can I contribute?
stukalin added a commit to stukalin/Gherkin that referenced this issue Nov 10, 2016
@stukalin
Behat#117 preparation
ffd34be
stukalin added a commit to stukalin/Gherkin that referenced this issue Nov 22, 2016
@stukalin
Behat#117 simple merging function was implemented
6f09f3d
stukalin added a commit to stukalin/Gherkin that referenced this issue Dec 8, 2016
@stukalin
Behat#117 preparation
5d1f3ee
stukalin added a commit to stukalin/Gherkin that referenced this issue Dec 9, 2016
@stukalin
Multiple example tables and tags support Behat#117
58c0ea1
stukalin added a commit to stukalin/Gherkin that referenced this issue Dec 9, 2016
@stukalin
Multiple example tables and tags support Behat#117
5058624
@stukalin stukalin mentioned this issue Dec 9, 2016
Closed
stukalin added a commit to stukalin/Gherkin that referenced this issue Dec 11, 2016
@stukalin
Multiple example tables and tags support Behat#117
cb0290d
stukalin added a commit to stukalin/Gherkin that referenced this issue Dec 11, 2016
@stukalin
Multiple example tables and tags support Behat#117
256c973
stukalin added a commit to stukalin/Gherkin that referenced this issue Dec 13, 2016
@stukalin
Multiple example tables and tags support Behat#117
10468a5
stukalin added a commit to stukalin/Gherkin that referenced this issue Dec 23, 2016
@stukalin
Behat#117 phpdoc and some rewording
cbc6c00
@volkyeth volkyeth mentioned this issue Jun 11, 2017
Closed
@tkotosz tkotosz mentioned this issue Nov 26, 2019
Open
dpakach pushed a commit to JankariTech/Gherkin that referenced this issue Dec 13, 2019
@stukalin @dpakach
Multiple example tables and tags support Behat#117
6886b1a
dpakach pushed a commit to JankariTech/Gherkin that referenced this issue Dec 13, 2019
@stukalin @dpakach
Behat#117 phpdoc and some rewording
628d53e
@dpakach dpakach mentioned this issue Dec 13, 2019
Merged
phil-davis pushed a commit to JankariTech/Gherkin that referenced this issue Jul 9, 2020
@stukalin @phil-davis
Multiple example tables and tags support Behat#117
a9da256
phil-davis pushed a commit to JankariTech/Gherkin that referenced this issue Jul 9, 2020
@stukalin @phil-davis
Behat#117 phpdoc and some rewording
10d213c
phil-davis pushed a commit to JankariTech/Gherkin that referenced this issue Jul 16, 2020
@stukalin @phil-davis
Multiple example tables and tags support Behat#117
84e26f8
phil-davis pushed a commit to JankariTech/Gherkin that referenced this issue Jul 16, 2020
@stukalin @phil-davis
Behat#117 phpdoc and some rewording
0141c2d
@phil-davis
Copy link
Contributor

PR #161 is the current incarnation of this feature. It is waiting for review.

phil-davis pushed a commit to JankariTech/Gherkin that referenced this issue Jul 21, 2020
@stukalin @phil-davis
Multiple example tables and tags support Behat#117
3ef8c9b
phil-davis pushed a commit to JankariTech/Gherkin that referenced this issue Jul 21, 2020
@stukalin @phil-davis
Behat#117 phpdoc and some rewording
5a7cf0f
phil-davis pushed a commit to JankariTech/Gherkin that referenced this issue Nov 12, 2020
@stukalin @phil-davis
Multiple example tables and tags support Behat#117
6a89c9b
phil-davis pushed a commit to JankariTech/Gherkin that referenced this issue Nov 12, 2020
@stukalin @phil-davis
Behat#117 phpdoc and some rewording
9a56a81
ciaranmcnulty pushed a commit that referenced this issue Jan 14, 2021
@dpakach @stukalin
Add support for multiple Example Tables with tags (#161)
dfc47a2 
* Multiple example tables and tags support #117

* #117 phpdoc and some rewording

* nesting reducing

* Fix the OutlineNode object for backward compatibility

Co-authored-by: Andrey Stukalin <Andrey.Stukalin@Vodafone.com>
Co-authored-by: Andrey Stukalin <apstukalin@gmail.com>
@individual-it
Copy link

is that fixed by #161 ?

@phil-davis
Copy link
Contributor

Yes, I will make some changes to examples tables in owncloud/core that will demonstrate it in "real life" and will link that here.
Behat/Gherkin 4.7.1 onwards supports this.

@ciaranmcnulty
Copy link
Contributor

Yes, this is now working I believe

@phil-davis phil-davis mentioned this issue Jan 28, 2021
Merged
11 tasks
@phil-davis
Copy link
Contributor

phil-davis commented Jan 28, 2021 •
edited
Loading

As an example, PR owncloud/core#38358 now uses multiple example tables in a scenario outline and works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ciaranmcnulty @phil-davis @individual-it @stukalin