Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new exception to exclude from logging #219

Merged
merged 3 commits into from
Apr 4, 2018
Merged

Conversation

sharidas
Copy link
Contributor

@sharidas sharidas commented Mar 13, 2018

Fixes #177, owncloud/core#30751

The already logs when the file is detected
with virus. So we don't have to log it as
an exception in the server. Hence added a
new exception.

Signed-off-by: Sujith H sharidasan@owncloud.com

@sharidas sharidas added this to the development milestone Mar 13, 2018
@sharidas sharidas self-assigned this Mar 13, 2018
@sharidas sharidas requested a review from VicDeo March 13, 2018 16:02
@CLAassistant
Copy link

CLAassistant commented Mar 13, 2018

CLA assistant check
All committers have signed the CLA.

@VicDeo
Copy link
Member

VicDeo commented Mar 27, 2018

Rebased. Let's see

@VicDeo
Copy link
Member

VicDeo commented Mar 27, 2018

Hm. Travis needs a core PR owncloud/core#30771 to pass.
Tests are passing locally, will test manually a bit more.

@VicDeo
Copy link
Member

VicDeo commented Mar 27, 2018

Fixes #177

sharidas and others added 2 commits March 28, 2018 20:28
The already logs when the file is detected
with virus. So we don't have to log it as
an exception in the server. Hence added a
new exception.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
Signed-off-by: Victor Dubiniuk <victor.dubiniuk@gmail.com>
@VicDeo
Copy link
Member

VicDeo commented Apr 3, 2018

owncloud/core#30771 is merged.
TODO here:

  • Raise min required OC version to 10.0.8 in info.xml to prevent 💥

@codecov-io
Copy link

codecov-io commented Apr 3, 2018

Codecov Report

Merging #219 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
+ Coverage     59.57%   59.66%   +0.08%     
  Complexity      270      270              
============================================
  Files            32       32              
  Lines          1180     1180              
============================================
+ Hits            703      704       +1     
+ Misses          477      476       -1
Impacted Files Coverage Δ Complexity Δ
lib/AvirWrapper.php 86.66% <100%> (ø) 24 <0> (ø) ⬇️
lib/Status.php 80% <0%> (+1.53%) 26% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d05f9...5de78f8. Read the comment docs.

Copy link
Member

@VicDeo VicDeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@VicDeo VicDeo merged commit 36bae7b into master Apr 4, 2018
@VicDeo VicDeo deleted the suppress-exception-log branch April 4, 2018 14:11
@patrickjahns patrickjahns modified the milestones: development, QA Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants