-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time display to viewer controls #225
Conversation
The code looks believable, but I am not the one to review JS. |
8413d2e
to
2684e45
Compare
@DeepDiver1975 fixed all your comments 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TypeError: moment.duration(...).format is not a function
at s.getDisplayTime (eval at globalEval (jquery.js:328), <anonymous>:13:215107)
at s.totalDisplayTime (eval at globalEval (jquery.js:328), <anonymous>:13:53036)
at mi.get (eval at globalEval (jquery.js:328), <anonymous>:7:26688)
at mi.evaluate (eval at globalEval (jquery.js:328), <anonymous>:7:27838)
at s.eval [as totalDisplayTime] (eval at globalEval (jquery.js:328), <anonymous>:7:29697)
@DeepDiver1975 you are challenging me 😄 |
Hello @DeepDiver1975 |
At least 00:24 / 00:30 I'd say. |
OK, will try to have fixed minutes and optional hours as suggested |
b2fe6e9
to
eb185ec
Compare
Hello @DeepDiver1975 implemented your suggestion |
@DeepDiver1975 may I ask for a review - would like to get this finalized 😃 |
eb185ec
to
8eec13b
Compare
Just seen that recently upgraded easytext from another PR we had a conflict in packages.json to be solved - done. @deepdiver please review so we can merge it - many thanks 😊 |
Based on the work of @tomschulze on original PR #223 and #224 (both closed).
Fixes #150 (suggestion from @hodyroff)
Tested on my dev environment and works as described
This adds the time to the video controls, pls see screenshot:
Original comment from @tomschulze:
A few remarks:
viewer__control__count
css class to style the display for test purposes (which disappears on small screens)totalDisplayTime
is computed because it doesn't change during the videogetDisplayTime()
in helper.js since it seemed more like a utility function to meshowTimeInfo()
aggregates the displayed string