New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add time display to viewer controls #224

Closed

tomschulze wants to merge 1 commit into owncloud:master from tomschulze:150-add-time-to-videos

tomschulze commented Apr 4, 2020

hi,
another try, since i committed merged code in the topic branch in the previous pull request (#223)
a few remarks:

i wasn't sure about your styling and i didn't wanna mess with your styles, so i used the viewer__control__count css class to style the display for test purposes (which disappears on small screens)
totalDisplayTime is computed because it doesn't change during the video
i put getDisplayTime() in helper.js since it seemed more like a utility function to me
the function showTimeInfo() aggregates the displayed string


          add time display to viewer controls

d8e1294

mmattel mentioned this pull request

Add time display to viewer controls #225

Merged

Contributor

mmattel commented Apr 4, 2020

Closing in favor of #225

mmattel closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet