Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] translations make, extract wrong texts for js files #547

Closed
AlexAndBear opened this issue Oct 25, 2021 · 0 comments · Fixed by #548
Closed

[l10n] translations make, extract wrong texts for js files #547

AlexAndBear opened this issue Oct 25, 2021 · 0 comments · Fixed by #548
Assignees
@AlexAndBear

Comments

@AlexAndBear
Copy link

AlexAndBear commented Oct 25, 2021 •
edited
Loading

  1. Run make l10n-read
  2. See files_mediaviewer.pot
  3. Only app name gets extracted

Actual

#: ../src/scripts/helper.js:53 ../src/scripts/init.js:49
msgid "files_mediaviewer"
msgstr ""

Expected

#: ../src/scripts/init.js:49
msgid "Open in Media Viewer"
msgstr ""
@AlexAndBear AlexAndBear self-assigned this Oct 25, 2021
This was referenced Oct 25, 2021
Merged
Closed
DeepDiver1975 added a commit that referenced this issue Oct 25, 2021
@DeepDiver1975
Merge pull request #548 from /issues/547
db83c1d 
xgettext should obey the second arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexAndBear AlexAndBear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xgettext should obey the second arg owncloud/files_mediaviewer
1 participant
@AlexAndBear