Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show current/total time #82

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Show current/total time #82

merged 1 commit into from
Jan 15, 2019

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Jan 14, 2019

Fixes #59 #78

Screenshot
screenshot_20190114_211632

@VicDeo VicDeo added this to the development milestone Jan 14, 2019
@VicDeo VicDeo self-assigned this Jan 14, 2019
@VicDeo VicDeo requested a review from PVince81 January 14, 2019 18:24
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit f40298c into master Jan 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-time-to-sublime branch January 15, 2019 09:47
@voroyam
Copy link

voroyam commented Jan 15, 2019

@VicDeo is there an ETA for the new Release?

@PVince81
Copy link
Contributor

The video player is bundled and has no marketplace entry, so the fix will be in the upcoming 10.1.0.

I'm not sure if we want to release the video player to marketplace as we have a new player (https://github.com/owncloud/files_mediaviewer) in the works. cc @pmaier1

@voroyam
Copy link

voroyam commented Jan 15, 2019

Not sure what to tell the customer.
On the one hand - Great news we have fixed it.
On the other hand - it may not get released.
No critique here, just thinking out loud.

@PVince81
Copy link
Contributor

it may not get released

it will definitely be released with ownCloud Server 10.1.0.
tell them to wait for that version then upgrade

alternatively you can have them apply the patch, which is likely to work on the 10.0.10 version of files_videoplayer

@voroyam
Copy link

voroyam commented Jan 15, 2019

Okay, thanks @PVince81

@PVince81
Copy link
Contributor

stable10: ab2c70d

seems we missed releasing this with 10.1 due to missing backport. will be in 10.2

@PVince81 PVince81 mentioned this pull request Apr 11, 2019
25 tasks
@PVince81 PVince81 modified the milestones: development, QA Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants