Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only activate uploading if we can write to the current folder #521

Closed
oparoz opened this issue Feb 13, 2016 · 9 comments
Closed

Only activate uploading if we can write to the current folder #521

oparoz opened this issue Feb 13, 2016 · 9 comments

Comments

@oparoz
Copy link
Contributor

oparoz commented Feb 13, 2016

Users will get an error message if they try to upload files where they're not allowed to, but it could be better to just block/disable the feature. The reason I'm not sure is that they would have no way of knowing if it's not available because of a permission problem or because of a bug.

Note: The upload functionalitiy is only available from 9.1, after merging #520 #574

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@mbtamuli
Copy link

@oparoz How do I work on this? I mean the VCS part. Can you help me with that? I want to work on this one.

@oparoz
Copy link
Contributor Author

oparoz commented Mar 10, 2016

If I understand your request correctly, you should fork the branch used in #520 in order to have all the uploading mechanism in your repository. After you've committed your solution, create a PR against that same branch and only your commits will show. Depending on when #520 is merged, we'll then either cherry pick your work or create a new, rebased branch.
There might be better ways, but that's how I do it. It does involve more work as both master and that branch might introduce small breaking changes.

@oparoz
Copy link
Contributor Author

oparoz commented Mar 10, 2016

And #574 superseded #520, so use that :)

@oparoz
Copy link
Contributor Author

oparoz commented Mar 11, 2016

This can now be worked on.

@mbtamuli
Copy link

I would like to work on this, if nobody else is already working on this.

@oparoz
Copy link
Contributor Author

oparoz commented Mar 12, 2016

OK, but I'm working on sending permissions to the client differently. It will be trivial to rebase if you read permissions with GalleryConfig, but I just wanted to let you know.

@mbtamuli
Copy link

Okay. Thanks for letting me know.

Also, are you not there on the irc channel?

@oparoz
Copy link
Contributor Author

oparoz commented Mar 12, 2016

The best way to get me on IRC is to ping me via email :)

@oparoz
Copy link
Contributor Author

oparoz commented Sep 4, 2016

This issue was moved to nextcloud/gallery#113

@oparoz oparoz closed this as completed Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants