Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort button hidden if only one image in album #576

Closed
wants to merge 1 commit into from
Closed

Sort button hidden if only one image in album #576

wants to merge 1 commit into from

Conversation

mbtamuli
Copy link

Fixes: #573

Licence: AGPL

Description

Sort buttons were shown irrespective of whether there was one or more images. If there is only one image, sort buttons need not be shown

Features

  • Sort buttons are now shown only when there are more than one

Screenshots or screencasts

one
many

Tested on

  • [*] Ubuntu 15.10/Chrome
  • [*] Ubuntu 15.10/Firefox

Reviewers

@oparoz This commit solves issue #573

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @oparoz to be a potential reviewer

@tahaalibra
Copy link
Contributor

👍 Working good..
tested using

  • Logged In
  • Public

NOTE: this is working only on images and not folder

@oparoz
Copy link
Contributor

oparoz commented Mar 10, 2016

@mbtamuli - Thanks for the PR, but please be careful. The task was already assigned to somebody else and it's best to ask that person's permission before taking over.

As discussed in #573, it should also work for folders. The approach is similar, but you have to find a way to count folders.

@mbtamuli
Copy link
Author

@oparoz Okay. Sorry. Will keep this in mind next time. Can you please mention other junior jobs I can work on? Preferably PHP based, although JS based tasks will also be fine.

@oparoz
Copy link
Contributor

oparoz commented Mar 10, 2016

@mbtamuli https://github.com/owncloud/gallery/issues?q=is%3Aissue+is%3Aopen+label%3A%22junior+job%22
Most are JS tasks.

Most task involve some JS. The ones which don't have already been selected for the GSoC AFAIK.

This one about the API is pure PHP: #408. The ajax calls have to be modified, but that's step2.

Also, Scrutinizer makes recommendations. Recently something was merged before it was ready and it could be improved: https://scrutinizer-ci.com/g/owncloud/gallery/inspections/3156c45f-e8b9-4852-9e6a-5f0f16a47a77

Missing unit tests could be written, etc.

@oparoz
Copy link
Contributor

oparoz commented Mar 10, 2016

Closing in favour of #577 . Feel free to help each other out :)

@oparoz oparoz closed this Mar 10, 2016
@oparoz
Copy link
Contributor

oparoz commented Mar 10, 2016

I've also added some basic app ideas to the wiki

@mbtamuli
Copy link
Author

Are you talking about these ideas 2016 (current)? Are these not for the GSoC event?

@oparoz
Copy link
Contributor

oparoz commented Mar 14, 2016

Sorry, I missed this message. I was talking about this:
https://github.com/owncloud/gallery/wiki/GSoC-2016#some-appframework-app-ideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants