-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort button hidden if only one image in album #576
Conversation
By analyzing the blame information on this pull request, we identified @oparoz to be a potential reviewer |
👍 Working good..
NOTE: this is working only on images and not folder |
@oparoz Okay. Sorry. Will keep this in mind next time. Can you please mention other junior jobs I can work on? Preferably PHP based, although JS based tasks will also be fine. |
@mbtamuli https://github.com/owncloud/gallery/issues?q=is%3Aissue+is%3Aopen+label%3A%22junior+job%22
Most task involve some JS. The ones which don't have already been selected for the GSoC AFAIK. This one about the API is pure PHP: #408. The ajax calls have to be modified, but that's step2. Also, Scrutinizer makes recommendations. Recently something was merged before it was ready and it could be improved: https://scrutinizer-ci.com/g/owncloud/gallery/inspections/3156c45f-e8b9-4852-9e6a-5f0f16a47a77 Missing unit tests could be written, etc. |
Closing in favour of #577 . Feel free to help each other out :) |
I've also added some basic app ideas to the wiki |
Are you talking about these ideas 2016 (current)? Are these not for the GSoC event? |
Sorry, I missed this message. I was talking about this: |
Fixes: #573
Licence: AGPL
Description
Sort buttons were shown irrespective of whether there was one or more images. If there is only one image, sort buttons need not be shown
Features
Screenshots or screencasts
Tested on
Reviewers
@oparoz This commit solves issue #573