Turn the Gallery button into a switch

[oparoz]

Implementation of #145

PR for ownCloud 8.0

@jancborchardt @libasys @nclm @deMattin, please test.

[oparoz]

I'm thinking the transition could be refined by clearing the view and showing the spinner since the whole page has to be reloaded... No idea if that's easily doable or if that really improves the user experience.

[jancborchardt]

Also cc @owncloud/designers, please review! :)

[oparoz]

This time I'm happy with the way it works.

Please review on 8.0 @jancborchardt @jospoortvliet @libasys @nclm @deMattin @setnes

[oparoz]

The ultimatedev branch for 8.1 contains this PR

[jancborchardt]

I fixed the style for the buttons: It was confusing as to what state is the current one:

Here for example I am in the files list, but the button definitely looks like I am in the Gallery view (button pressed and looks disabled). So I simply switched the styles around:

[jancborchardt]

Another thing: I would say we should put this switcher on the far right of the controls bar. Otherwise it takes focus away from the New & Upload buttons.

[jancborchardt]

We should put this switcher on the far right of the controls bar. Otherwise it takes focus away from the New & Upload buttons.

Done with the newest commit :)

[oparoz]

I agree for the Files/Gallery switch, but it's going to be a problem with the sorting buttons since each button has 2 functions: activate the sort and change the order. Any idea on how to solve that?

Historically, that button has always been on the left, but I'm happy with the change if that's the new way forward :)

[jancborchardt]

There’s only one problem now: The sort by date / name toggle doesn’t have a pressed state anymore. Can you add the .disabled-button logic to it because that’s the class we use now?

[jancborchardt]

activate the sort and change the order

What do you mean by »activate the sort«? Isn’t the default sort by date?

[oparoz]

The default is by date, but if you click on the button again, you change the order. If that button is marked as disabled, then you can't do that any more and if it's greyed out, people won't think of using it.

[oparoz]

A 3rd button to change the order is always an option, but it's starting to get crowded up there... No?

[oparoz]

A dropdown is another option, but that means a minimum of 2 clicks for every change, unless we use a hover.

[jancborchardt]

The default is by date, but if you click on the button again, you change the order.

Aaah right! Yeah, a third button would be too much. I’m thinking if it would be better to have one button for sorting in there which drops down a menu where you can choose:

• Newest first
• Oldest first
• Alphabetically

I don’t think that’s too bad regarding the 2 clicks because it’s something which is not changed so often, eh?

[jancborchardt]

The other question is: Do we really need reverse chronological order?

[jancborchardt]

From my side only #311 is necessary, and I still think we should merge that instead of relying on this very large pull request first. We can then rebase this to go forward.

@oparoz we have core feature freeze today so please make sure we merge #311 today – or if you choose to merge this, make sure it looks like intended by #311

[karlitschek]

yes. would be great to get this in. The rest can be done for the next release.

[oparoz]

#311 cannot be merged, it doesn't look right on the Gallery side

3 button styles in one app

[oparoz]

This PR isn't large, it's just swapping things around and has a more generic way of building buttons.
I'll prioritise adding the #311 changes to the Files side only, but the Gallery side also needs to be fixed as there will still be 2 different button designs after that

• Turn the switch-type buttons for Files/Gallery into single buttons
• Make the button on the Files side transparent

[jancborchardt]

@oparoz that looks totally fine with the view switcher.

• sharing should be in the breadcrumbs, as discussed (without the button style as well)
• the info icon won’t be there by default for most
• the sorting buttons, again, should be behind a dot-dot-dot icon-more icon.

[oparoz]

The sharing button can't go on the left, see #148 (comment)

The sorting buttons can be hidden later. We just can't have a UI in transition and which looks broken to users.

[oparoz]

Files view

[jancborchardt]

Cool! :) See, the files view looks much nicer now with the way less obtrusive switcher.

[oparoz]

I'm still not convinced, but it's more difficult to make the switch work with a flat design which has no borders or colours and very little foreground/background contrasts. I would probably have to play with the size of the button or something, but I would love to see the full UI elements sheet at some point.
I'll test both button types on Gallery+ to see which works best, but for older versions I'll keep the switch since buttons still have borders.

For sorting, it's more complex since there are 3 states, so one of them has the same border as the hover, because white on white doesn't work. We'll see how that evolves.

Gallery view

[jospoortvliet]

I know it's painful... But the end result does look good. I guess - no pain = no gain, right?

[karlitschek]

yes. this is a good solution. Thanks guys