Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back smooth scrolling #507

Merged
merged 1 commit into from
Feb 12, 2016
Merged

Bring back smooth scrolling #507

merged 1 commit into from
Feb 12, 2016

Conversation

oparoz
Copy link
Contributor

@oparoz oparoz commented Feb 9, 2016

First attempt at fixing #500.

The improvements range from not visible to astonishing on the devices I've tested. The devices which benefit the most seem to be iOS based.

This introduces the changes that @fuhaoshih tried to introduce with #285, but without the side effects (at least in the scrolling).

The best quick test you can do is scroll through a list of files on the Files side and then switch to Gallery and scroll again.

The standard and public templates should be combined in a future PR as they're very similar now.

Platforms

Desktop

  • Chromium/win10: no visible change
  • Firefox/win10: no visible change
  • Edge/win10: no visible change
  • IE11/win10: no visible change

Mobile

  • Chrome/ios9: huge performance gains. Activates smooth kinetic scrolling
  • Safari/ios9: huge performance gains. Activates smooth kinetic scrolling with bouncing edges
  • Browser/BB10: improves scrolling performance
  • Chrome/Android 4.x: huge performance gains. Activates smooth kinetic scrolling
  • Firefox/Android 4.x: no visible change. Seems like hardware acceleration is not available on 4.x
  • Chrome/Android 5.x
  • Firefox/Android 5.x
  • Chrome/Android 6.x
  • Firefox/Android 6.x

@jancborchardt @Henni @setnes @deMattin @mmattel @Spacefish @Bugsbane @MorrisJobke @jospoortvliet

@oparoz oparoz added this to the 9.0-current milestone Feb 9, 2016
@oparoz oparoz self-assigned this Feb 9, 2016
@oparoz oparoz mentioned this pull request Feb 11, 2016
8 tasks
@oparoz oparoz modified the milestones: 9.1-next, 9.0-current Feb 11, 2016
@oparoz oparoz added the bug label Feb 11, 2016
@oparoz
Copy link
Contributor Author

oparoz commented Feb 12, 2016

I've performed some tests to make sure it wouldn't block any future template extension and we will have to write our own CSS in order to be able to keep a smooth photowall or wait for core to fix their templates before trying to add a navigation panel.

oparoz added a commit that referenced this pull request Feb 12, 2016
@oparoz oparoz merged commit 451d72c into master Feb 12, 2016
@MorrisJobke MorrisJobke deleted the fix-scrolling branch February 12, 2016 06:19
@oparoz oparoz removed the QA-testing label Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants