-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official drag and drop support #581
Conversation
By analyzing the blame information on this pull request, we identified @raghunayyar, @jancborchardt and @imjalpreet to be potential reviewers |
48b822b
to
7b52960
Compare
It's ready to review again. Test plan has been updated. |
@oparoz All the tests successfully passed! 👍 Logged In
Public
Tested on -
Two other warnings came up, though maybe not due to this PR.
|
Thanks @mbtamuli . The deprecation warning comes from |
tested on various conditions...working fine...only thing is that no option editing permission and also i can drag and drop files/folder in public view....it fails but i think it would be better to remove the option of drag and drop in public view( when editing permission is not given ) |
@tahaalibra - Permission checking on the public side shouldn't be too hard to implement for anybody once this is merged :) |
You need to tap and hold to be able to move elements
HTML5 data properties can be anything and if a folder only contains numbers as its name it will be considered a number and String operations will fail
7b52960
to
fe25174
Compare
Solution for #405, replaces #519
Possible improvements
Drop targets could be nicerDoneDragged albums maybe need a border?After extensive use, I don't think soScreencasts
http://screencast-o-matic.com/watch/cDnl0rhWt7
Screenshot
Test plan
Name at least one file and one folder with numbers only
As a logged-in user:
Do the same on the public side, but make sure you've added the "editing" permission to the link.
Caveats
Read the FAQ in #405
TODO
@jancborchardt @jospoortvliet @setnes @deMattin @arkascha @elpraga @sualko @Bugsbane @mmattel
@karlitschek @LukasReschke @tahaalibra @viraj96 @imjalpreet @mbtamuli @rahulgoyal030