-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #565: Add the checkbox in the share dialogue to allow uploading from the public side #587
Conversation
By analyzing the blame information on this pull request, we identified @oparoz, @PVince81 and @Spacefish to be potential reviewers |
Either of #586 or this one will have to be rebased upon merging of the other one. |
Yeah, no problem |
Sorry this wasn't much work. Looks like I had already fixed most of it. |
@@ -245,19 +245,18 @@ | |||
html += '</div>'; | |||
|
|||
// FIXME public uploading is not supported in Gallery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove
@oparoz No problem. |
@@ -174,19 +174,19 @@ | |||
// respective checkbox should be checked or | |||
// not. | |||
// FIXME public uploading is not supported in Gallery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove
Code looks good and it works 👍 |
@viraj96 @mbtamuli @tahaalibra Please test this. |
…ploading from the public side
Rebased the commit. |
Issue #565: Add the checkbox in the share dialogue to allow uploading from the public side
@imjalpreet - I wasn't careful enough when merging... You need to update the failing test. Just do it in a new PR. Should take 5 minutes to do. That way I don't need to revert this. |
@oparoz Sorry, I forgot about that. I will send a new PR soon. 👍 |
Fixes: #565
Licence: AGPL
Description and Features
Screenshots or screencasts
Tested on
Test Plan
As a logged-in user:
Reviewers
@oparoz Please have a look at this.