Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send information about albums to the client #593

Merged
merged 2 commits into from
Mar 16, 2016
Merged

Send information about albums to the client #593

merged 2 commits into from
Mar 16, 2016

Conversation

oparoz
Copy link
Contributor

@oparoz oparoz commented Mar 13, 2016

Description

This is the first step to solve #557 and will help with a lot of current features like upload, drag n'drop and sharing.

What it does is send a bit more meta data about each file, but a lot more about sub-albums (fileId, mTime, etag, size, sharedWithUser, owner, freeSpace, permissions).

The change is quite large, so test thoroughly.

Tested on

  • Windows/Firefox
  • Windows/Chrome

Test plan

Setup

  • Blacklist some albums
  • Have some deeply nested albums

Actions

  • Test both the logged-in and public side as internal paths are different
  • Navigate to and out of folders
  • Upload files and folder
  • Move files and folder around

Tech review

  • Instead of sending a list of nodes and letting the client parse it to extract albums and files, the backend sends a array for each
  • $privacyChecker has been renamed $ignoreAlbum as the blacklist feature is just a filter for the view
  • The backend doesn't let the client know if the location has changed any more. The client simply compares the path it's sent with the one it receives
  • Every answer to a request for files will let the client know if the content has changed (bool)
  • item-source is made available to share.js

Check list

  • Code is properly documented
  • Commits have been squashed
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Reviewers

@jospoortvliet @setnes @deMattin @arkascha @elpraga @sualko @Bugsbane @mmattel @tahaalibra @viraj96 @imjalpreet @mbtamuli @rahulgoyal030

oparoz added 2 commits March 16, 2016 14:51
The albumMap is used for navigation, so it's important to build it whenever the user enters the app
oparoz added a commit that referenced this pull request Mar 16, 2016
Send information about albums to the client
@oparoz oparoz merged commit b3ec2a4 into master Mar 16, 2016
@oparoz oparoz deleted the subalbum-info branch March 16, 2016 14:30
@oparoz oparoz self-assigned this Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant