Rename: thumbnail glitches

[michaelstingl]

distorted thumbnail (before view/download)	no thumbnail (after view/download)

---

• a03260e on iPhone 7 Plus running iOS 12.1
• ownCloud 10.0.10

[michaelstingl]

Related? owncloud/core#31268

[pablocarmu]

I've been looking at this and:

1. The distorted image is because the contentMode of the imageView was not set to scaleAspectFit
2. The no thumbnail is because this method is returning false

- (BOOL)requestImageForSize:(CGSize)requestedMaximumSizeInPoints scale:(CGFloat)scale withCompletionHandler:(void(^)(OCItemThumbnail *thumbnail, NSError *error, CGSize maximumSizeInPoints, UIImage *image))completionHandler

So there is no thumbnail image for this image. Also, I've taken a look at the implementation and the error in the withCompletionHandler is always hardcoded to nil.

this is the call sequence the app does to get the thumbnail from the SDK:

			if item.thumbnailAvailability != .none {
				_ = core!.retrieveThumbnail(for: item, maximumSize: self.thumbnailSize, scale: 0, retrieveHandler: { (error, _, _, thumbnail, _, _) in
					_ = thumbnail?.requestImage(for: self.thumbnailSize, scale: 0, withCompletionHandler: { [weak self] (thumbnail, error, _, image) in
						if error == nil,
							image != nil,
							item.itemVersionIdentifier == thumbnail?.itemVersionIdentifier {
							OnMainThread {
								self?.thumbnailImageView.image = image
							}
						}
					})
				})
			}

image is nil so it never set up the image.

I've checked if there is some error in

core!.retrieveThumbnail(for: item, maximumSize: self.thumbnailSize, scale: 0, retrieveHandler: { (error, _, _, thumbnail, _, _) in

and there is no signal of error, even the thumbnail is not nil. I'm missing something here or doing the wrong calls @felix-schwarz ?

[michaelstingl]

Maybe related: I've seen old iOS app and Android app show thumbnail of already downloaded *.HEIC. (of course no thumbnail for remote-only *.HEIC) But new iOS app can display downloaded *.HEIC, but doesn't display a thumbnail when already downloaded.

[felix-schwarz]

Fixed from the SDK side as of owncloud/ios-sdk@1c59788

Fix for aspect ratio on the app side still missing.

[felix-schwarz]

As of 4ce416e, the aspect ratio is fixed in the app, too.

[pablocarmu]

Tested with the latest App's master and SDK's develop branches and it's fixed.
@jesmrec when you have time please check it so we can close this

[jesmrec]

Current ios-app/master : b734533
Current ios-sdk/develop : b36850e8d274a45416080560eec6ad37aede1d41

not compiling together

[michaelstingl]

@felix-schwarz what should be used? ios-sdk/develop or ios-sdk/master ?
(https://github.com/owncloud/ios-sdk/network)

[felix-schwarz]

@jesmrec @michaelstingl Yes, the develop branch contains breaking changes as of a few hours ago. If you want to test against the current ios-app/master, you should check out ios-sdk/develop at 1c597883a824b876a71a5f6caf13aa4d6a99255f (which is not containing the sync engine updates, though).

Alternatively, you can try with ios-app/fp-series-2, which uses the latest from ios-sdk/develop. Once the changes from ios-sdk/develop have made it to ios-sdk/master, I'll extract non-FP-related changes into a separate ios-app/fix/sdkUpdates PR.

[jesmrec]

Fixed in features/fp-series-2