Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] More view #82

Closed
javiergonzper opened this issue Jun 18, 2018 · 7 comments
Closed

[UX] More view #82

javiergonzper opened this issue Jun 18, 2018 · 7 comments
Assignees
@pablocarmu
Labels
Design discussion

Comments

@javiergonzper
Copy link
Contributor

javiergonzper commented Jun 18, 2018 •
edited
Loading

As a user, i want interact with a file in order to do actions

AC:

  • The more view should be shown when the user tap on the More button that should appear in:
    • "The Preview" of the file
    • The row of the file in the "File List"
  • Take into account the capabilities to hide the Share if the API is not available
  • Share:
    • Show all the current shares (by user, group, link)
    • Add a new share
    • Edit an old share to change the properties
  • Actions

Mockups:

Both mockups are the same More view one with text buttons and other with system buttons

Text buttons
more view text buttons

System buttons
more view icon

Taking into account Extremely long filenames:
more view - extremely long filenames
@michaelstingl
Copy link
Contributor

@javiergonzper System buttons look good too 👍

@jesmrec
Copy link
Contributor

jesmrec commented Jun 21, 2018

system buttons much better. I guess the (+) button will include the options the create both public and private shares.

@javiergonzper
Copy link
Contributor Author

Added a mockup with a Extremely long filenames related to the issue: #88

cc: @michaelstingl

@skwale
Copy link

skwale commented Jul 5, 2018

i need owncloud to be integrated in Files app like Dropbox or box

@javiergonzper
Copy link
Contributor Author

i need owncloud to be integrated in Files app like Dropbox or box

Hi @skwale we are working on it 👍
Here you have the issue: #11

@atwm
Copy link

atwm commented Jul 5, 2018 •
edited
Loading

Previews for RAW files (photos). Raw files normally include jpeg previews which can be extracted and shown

@michaelstingl
Copy link
Contributor

@atwm cool idea, should be discussed in #85

@pablocarmu pablocarmu self-assigned this Aug 16, 2018
pablocarmu pushed a commit that referenced this issue Aug 17, 2018
- Created the MoreViewController for the More Screen following the de…
73feb4f 
…sign guidelines described in #82

- Created new init methods in StaticTableViewRow and StaticTableViewSection to support NSAttributedString as titles.
- Created new UIPresentationController called CardPresentationController to support the presentation of a view controller in a "card" way.
- Coded support for NSAttributedString in ThemeTableViewCell.
@pablocarmu pablocarmu mentioned this issue Aug 17, 2018
Merged
9 tasks
pablocarmu pushed a commit that referenced this issue Aug 21, 2018
- Created the MoreViewController for the More Screen following the de…
4a2482d 
…sign guidelines described in #82

- Created new init methods in StaticTableViewRow and StaticTableViewSection to support NSAttributedString as titles.
- Created new UIPresentationController called CardPresentationController to support the presentation of a view controller in a "card" way.
- Coded support for NSAttributedString in ThemeTableViewCell.
pablocarmu pushed a commit that referenced this issue Aug 22, 2018
- Created the MoreViewController for the More Screen following the de…
907bd49 
…sign guidelines described in #82

- Created new init methods in StaticTableViewRow and StaticTableViewSection to support NSAttributedString as titles.
- Created new UIPresentationController called CardPresentationController to support the presentation of a view controller in a "card" way.
- Coded support for NSAttributedString in ThemeTableViewCell.
jesmrec pushed a commit that referenced this issue Sep 3, 2018
@pablocarmu @jesmrec
Feature/more (#106)
b8c0e2c 
* - Created the MoreViewController for the More Screen following the design guidelines described in #82
- Created new init methods in StaticTableViewRow and StaticTableViewSection to support NSAttributedString as titles.
- Created new UIPresentationController called CardPresentationController to support the presentation of a view controller in a "card" way.
- Coded support for NSAttributedString in ThemeTableViewCell.

* - Decoupled the MoreViewController into 3 different files

* - Little tweak in CardPresentationController for landscape on iPhone.
- Coded the size of the item as detail label in the more header.

* - SDK Updated to file management branch to be able to use progress.
- Coded the rename feature using the more view.

* - Made the detail font size match the proposed design.
- Now the detail label in the MoreHeaderView shows the last modified date of an OCItem.

* - Turn on scrolling for MoreStaticTableViewController created in ClientQueryViewController
- Figured out card-style scrolling:
	- until the card is fully "open": all pan gestures move the card
	- once the card is fully "open":
		- pans in UIScrollView upwards scroll the scrollView up
		- pans in UIScrollView downwards
			- scroll the scrollView down if its position is not already at the top
			- move the card if the scrollView's position is already at the top

* - Improved support for themes inside the MoreStaticTableViewController.

* - CardPresentationController now respects the size of the content, can't be extended beyond the maximum size of the content
- Make MoreStaticTableViewController adopt dynamic sizing/auto layout
- Fix formatting
- Fix SwiftLint warnings
- Add missing license texts

* - avoid creating gesture recognizers that aren't used and clarify cardPanGestureRecognizer and dimmingViewGestureRecognizer types
- add overStretchView that is attached below the presentedView
- make sure containerViewWillLayoutSubviews isn't interferring with animations / user drags
- considering that the card won't permanently extend beyond the size of the card, default the cardPosition to .open to show as much of the card as possible

* - Move dragHandleView into CardPresentationController
- Make taps on the drag handle dismiss the card
- Add support for iPhone X safe areas to CardPresentationController
- CardPresentationController dynamically makes MoreViewController disable scrolling if it fits entirely on screen
- unified dismiss code
- added convenience method to UIViewController to quickly present a view controller as a card
- cleaned up static table view code and made the moreViewController use "buttonWithAction"
- added support for non-opaque buttons to StaticTableViewRow
- cleaned up MoreViewController constraints and fixed an exception/warning during rotation
- fixed thumbnail size in MoreViewHeader
- rewrote MoreViewHandler constraint code
- Fix indentations in various places

* - avoid duplicate code for rename and delete inside ClientQueryViewController
- ClientQueryViewController gains new methods for folder creation, rename and delete
- added titles to "New folder" and "Rename" actions
- fix missing spacing of sortbar when rotating in iPhone X and using in landscape
- improved text in alerts
- remove NSAttributedStringKey extension as its no longer needed

* Moving headerAttributedTitle and footerAttributedTitle support from StaticTableViewSection to MoreStaticTableViewSection, as the properties are only used by MoreStaticTableViewController.
@jesmrec jesmrec closed this as completed Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pablocarmu pablocarmu

Labels
Design discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@michaelstingl @skwale @javiergonzper @atwm @pablocarmu @jesmrec