Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/server-side-search] Add server-side search support #1419

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

felix-schwarz
Copy link
Contributor

@felix-schwarz felix-schwarz commented Nov 2, 2024

Description

This PR adds server-side search support to the app.

TODO

  • add search scope backed by OCSearchResult
  • improve error and result handling in OCSearchResult
  • add KQL syntax generator to OCQueryCondition (similar to the SQL syntax generator)

Related Issue

Screenshots (if appropriate):

Bildschirmfoto 2024-11-08 um 09 22 28

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

- ProgressSummarizer: add support for new OCEventType .search
@felix-schwarz felix-schwarz self-assigned this Nov 2, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

	- add CollectionViewCellStyle.showPathDetails property
	- add CollectionViewCellStyle.StyleOptionKey.showPathDetails
- OCItem+UniversalItemListCellContentProvider: add support for CollectionViewCellStyle.showPathDetails
- ServerSideSearchScope: add server-side search scope
- SearchScope: add convenience method to instantiate ServerSideSearchScope
- ClientItemViewController: add server-side search scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants