Feature/thumbnails

[felix-schwarz]

Add thumbnail support:

BUGS & IMPROVEMENTS

• (1) Browsing again to a folder does not display thumbnail Feature/thumbnails #32 (comment) [FIXED]
• (2) Scroll down Feature/thumbnails #32 (comment) [FIXED]

[pablocarmu]

If you update this branch with what the current master branch has (via rebase) you could get the onMainThread function and wrap the call into:

OnMainThread {
 self.iconView.image = image
}

[felix-schwarz]

Good point! Thanks.

[pablocarmu]

Also in Swift you can chain multiple if statements with a ,. Don't know which option is more clear to you if the one with three if statements or chain them like:

if error == nil, image != nil, self.item?.versionIdentifier == thumbnail?.versionIdentifier {
  OnMainThread {
       self.iconView.image = image
   }
}

[felix-schwarz]

Good idea. I made that change.

[pablocarmu]

I think the displayThumbnail closure is taking the unused thumbnail?.requestImage(...) Bool return as it's own return parameter and this is why it's saying to you Result of call is unused, but produces 'Bool?' when you later call displayThumbnail(thumbnail) if you don't assign it's return value to some variable ( in this case to a _)

You can get rid of this _ assignment if you code it here:

_ = thumbnail?.requestImage(for: thumbnailSize, scale: 0, withCompletionHandler: { (thumbnail, error, _, image)

then you can call the displayThumbnail(thumbnail) without any assignment:

displayThumbnail(thumbnail)

[felix-schwarz]

Thanks. Made that change as well.

[jesmrec]

(1) [FIXED]

1. Browse into a folder with pics (thumbnails downloaded and displayed)
2. Browse back to parent folder
3. Browse again to folder in 1.

Current: Thumbnails not displayed
Expected: Thumbnails displayed

[jesmrec]

(2) [FIXED]

1. Open the app with pics in root folder (thumbnails displayed)
2. Scroll down
3. Scroll up

Current: Thumbnails in 1. not displayed
Expected: Thumbnails displayed

[jesmrec]

Formats that thumbnails are not displayed: TIFF, SVG.

[felix-schwarz]

The latest commit fixes the issues (1) and (2).

Regarding TIFF and SVG: right now, the app should request thumbnails for all items.

Chances are the server you're testing against doesn't provide thumbnails for this format.

[jesmrec]

All stuff fixed. Approved.