Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

[Share] As an OC user I want to be able to share data with ownCloud users #425

Closed
rperezb opened this issue Jul 28, 2015 · 26 comments
Closed

Comments

@rperezb
Copy link

rperezb commented Jul 28, 2015

AC:

  • When I do swipe over a file/folder, it will be shown an option called: Share
  • This implies that the Share Link option will be overwrittent
  • Having selected the Share option a new view is shown, see mockup
    • The mimetype of the file is added
    • The file name is shown and the path where it is stored
    • There is an option, "share with user or group" same idea as the web interface, it is typed the name of the user with whom it will be shared, by tapping on the decided user, it will be shared with him
    • Below the search tool, those users with whom the file or folder is shared are listed
    • First iteration, it won't be possible to modify privileges neither to stop sharing with a user
    • Below of the shared users it will be offer a check button: Share link, once this button is enable, it will be generated the link
    • The user may device to share the link with password enable or with expiration time

NOTE:

  • This is a global issue, as we usually work, this has to be divided in vertical issues so that we split the job
  • This is the very first idea, we need other users feedback

@MTRichards @jancborchardt @cmonteroluque @javiergonzper @ggdiez @nasli @purigarcia

screen shot 2015-07-28 at 17 54 14

@rperezb
Copy link
Author

rperezb commented Jul 28, 2015

#336

@jancborchardt
Copy link
Member

@rperezb @javiergonzper @ggdiez @nasli @purigarcia looks good in general, but please use iOS 8 as base for your mockups? :D

@rperezb
Copy link
Author

rperezb commented Jul 28, 2015

@jancborchardt yes 😵 it was the tool, http://pencil.evolus.vn/ it is not updated...
I have to look into other tools
The main thing was to start a discussion, @MTRichards wants to start working on it...pretty soon 👍

@ggdiez
Copy link
Member

ggdiez commented Jul 29, 2015

Hi @jancborchardt @rperezb @nasli @purigarcia @MTRichards @cmonteroluque

Using the Raquel idea these are my mockups. The structure of the view is the same but I have done some changes.

  • The search option better in other view as Google Drive.
  • The checkbox of the Shared Link, I prefer use a switch, you can also use the switch for un-share option.

My mockup:

Shared 0 view, it's the view when the user tap in share option on a not shared file.

Shared 1 view, it's when the user have share the file with an user and shared by link with password and password protect options.

Find user view, it's when the user tap in "Add User or Group" button. In this view the user can search for the user/users or group/groups to share the file and the permissions.

shared 0
shared 1
find user

@tobiasKaminsky
Copy link

I like the latest three mockups.
But the permission options has to be editable for every user individually.
So maybe these settings can popup when the user selects a user/group.
And after that it is shown by icons and can be edited via long-click

@ggdiez
Copy link
Member

ggdiez commented Jul 30, 2015

@cmonteroluque @MTRichards @PVince81 @DeepDiver1975
Is there an API in the server side to search for users or groups with a filter?

@ggdiez
Copy link
Member

ggdiez commented Jul 30, 2015

@tobiasKaminsky for the first iteration the part of the permissions is not included. So the mockup of the third image will be the same without the "options" section.

But I'm thinking in a solution for the next iteration. ;)

Thanks

@tobiasKaminsky
Copy link

@jancborchardt pointed me to this issue as I am developing for android and he said it would be good that both apps have a similar behaviour.
Therefore it would be great to think everything to the end :)

So, do you think it would work with a popup? With this the list of the user would not be truncated by the options menu.

@jancborchardt
Copy link
Member

We can simplify this. The »Share with user or group …« section should not be a popup. It should be much like the web interface dropdown, with the »can edit« and »can share« sections in the same line of the username, to the right.

I’ll work on a mockup.

@ggdiez
Copy link
Member

ggdiez commented Aug 3, 2015

I have checked the Share API documentation and there are no way to know if a file shared by link have password protected enabled.

As @schiesbn said me the only way for the moment is use the "share_with" column in the response. It's ugly but there are not other way.

@rperezb
Copy link
Author

rperezb commented Aug 5, 2015

@ggdiez WIP the server API owncloud/core#16646

@rperezb
Copy link
Author

rperezb commented Aug 5, 2015

related to the desktop client: owncloud/client#3537 and android: owncloud/android#880

@tobiasKaminsky
Copy link

@jancborchardt

We can simplify this. The »Share with user or group …« section should not be a popup. It should be much like the web interface dropdown, with the »can edit« and »can share« sections in the same line of the username, to the right.
I’ll work on a mockup.

A mockup would be great.

@DeepDiver1975
Copy link
Member

consolidated server api spec is here - owncloud/core#18117

@bsElyes
Copy link

bsElyes commented Aug 24, 2015

Any News about this work ? :D

@rperezb
Copy link
Author

rperezb commented Aug 24, 2015

Work in progress, first part is the OCS- Api, then we will update the iOS client.
In the meantime, we are working on the new view, https://github.com/owncloud/ios/tree/share_by_link_with_options

@guruz
Copy link
Contributor

guruz commented Aug 31, 2015

^^ FYI @dragotin @ogoffart @rullzer @jturcotte etc if we do this in the client, it could look similar

@rperezb
Copy link
Author

rperezb commented Aug 31, 2015

Yes, it would be great!

Indeed, you are welcome to the mobile and pals room @ownclouders conference, we may talk about it and the flow 😄

@jancborchardt
Copy link
Member

BTW: As live mockup essentially, please look at how it is done on the server – this is always the master regarding design. For specific optimizations it will be mostly showing stuff directly (to not need to type on mobile), but we already talked about that @rperezb :)

@rperezb
Copy link
Author

rperezb commented Sep 2, 2015

Yes, we talked about it, mostly we will follow #425 (comment)
We will add and i, closed to the user name so that when it´s clicked it may be modified the privileges and remove the share

@rperezb
Copy link
Author

rperezb commented Sep 16, 2015

For the next version, 3.4.5, the first step is done, add a new share view and add additional options for the sharelink (expiration date and password)
Share with other users will come in the next version

@rperezb rperezb added this to the 3.4.6-next milestone Sep 16, 2015
@rperezb rperezb removed this from the 3.4.5-current milestone Sep 16, 2015
@rperezb
Copy link
Author

rperezb commented Sep 29, 2015

Share with users in progress on: https://github.com/owncloud/ios/tree/sharee_with_user

@jancborchardt
Copy link
Member

@rperezb @ggdiez @javiergonzper @nasli show screenshots as soon as you can please. :)

@rperezb
Copy link
Author

rperezb commented Oct 13, 2015

screen shot 2015-10-13 at 11 26 40
screen shot 2015-10-13 at 11 26 59
screen shot 2015-10-13 at 11 33 10
screen shot 2015-10-13 at 11 32 40

@rperezb
Copy link
Author

rperezb commented Oct 13, 2015

another one to show how errors are handled:
screen shot 2015-10-13 at 17 36 37

@rperezb
Copy link
Author

rperezb commented Oct 27, 2015

This is done and it will be available within the next ownCloud iOS versions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants