Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app roles and assignments #76

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Add app roles and assignments #76

merged 2 commits into from
Jan 3, 2023

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jan 2, 2023

Description

Add a minimum viable implementation of the msgraph appRoleAssignment to assign roles to users per school:

principalId: The id of the user to whom you are assigning the app role.
resourceId: The id of the resource servicePrincipal that has defined the app role.
appRoleId: The id of the appRole (defined on the resource service principal) to assign to the user.

@micbar
Copy link
Contributor Author

micbar commented Jan 2, 2023

@butonic Still missing: List App roles endpoint

I found GET /application/{application-id} which has an appRoles property.

api/openapi-spec/v1.0.yaml Outdated Show resolved Hide resolved
api/openapi-spec/v1.0.yaml Outdated Show resolved Hide resolved
api/openapi-spec/v1.0.yaml Outdated Show resolved Hide resolved
@micbar
Copy link
Contributor Author

micbar commented Jan 2, 2023

@janackermann @fschade FYI

api/openapi-spec/v1.0.yaml Outdated Show resolved Hide resolved
@micbar micbar force-pushed the add-roles branch 6 times, most recently from 443bc9a to 0bd71e6 Compare January 3, 2023 11:49
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good IMO. Just some minor wording tweaks.

api/openapi-spec/v1.0.yaml Outdated Show resolved Hide resolved
api/openapi-spec/v1.0.yaml Outdated Show resolved Hide resolved
Co-authored-by: Jörn Friedrich Dreyer <jfd@owncloud.com>
@butonic butonic merged commit 4e8bd59 into main Jan 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-roles branch January 3, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants