-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app roles and assignments #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbar
requested review from
dragotin,
butonic,
kulmann and
rhafer
as code owners
January 2, 2023 15:54
@butonic Still missing: List App roles endpoint I found |
micbar
commented
Jan 2, 2023
micbar
commented
Jan 2, 2023
micbar
commented
Jan 2, 2023
micbar
commented
Jan 2, 2023
micbar
force-pushed
the
add-roles
branch
6 times, most recently
from
January 3, 2023 11:49
443bc9a
to
0bd71e6
Compare
butonic
approved these changes
Jan 3, 2023
rhafer
reviewed
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks good IMO. Just some minor wording tweaks.
Co-authored-by: Jörn Friedrich Dreyer <jfd@owncloud.com>
rhafer
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a minimum viable implementation of the msgraph appRoleAssignment to assign roles to users per school:
principalId: The id of the user to whom you are assigning the app role.
resourceId: The id of the resource servicePrincipal that has defined the app role.
appRoleId: The id of the appRole (defined on the resource service principal) to assign to the user.