Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the validate step before publish, add gofmt to validate #80

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Run the validate step before publish, add gofmt to validate #80

merged 2 commits into from
Jan 5, 2023

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Jan 5, 2023 •
edited
Loading

To avoid publishing code that doesn't validate. Also run the generated code through gofmt.

@rhafer rhafer requested review from butonic and micbar January 5, 2023 10:06
@rhafer rhafer self-assigned this Jan 5, 2023
@rhafer rhafer force-pushed the gofmt branch 2 times, most recently from cbda0c2 to 6f85a41 Compare January 5, 2023 10:08
@rhafer
Run the validate step before the publish step
0b5eb8a 
To avoid publishing code that doesn't validate.
@rhafer rhafer changed the title Run the validate step before the publish step Run the validate step before publish, add gofmt to validate Jan 5, 2023
@rhafer rhafer marked this pull request as ready for review January 5, 2023 10:18
@butonic butonic merged commit 156f5c7 into owncloud:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@micbar micbar Awaiting requested review from micbar

Assignees

@rhafer rhafer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhafer @butonic