Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always return an int from Symfony Command execute method #1233

Merged
merged 1 commit into from
May 18, 2023
Merged

Always return an int from Symfony Command execute method #1233

merged 1 commit into from
May 18, 2023

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented May 18, 2023 •
edited
Loading

Symfony 5 will require this, so be prepared.
For Symfony 4 it is optional.

Preparation for owncloud/core#39630

@phil-davis phil-davis self-assigned this May 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@phil-davis phil-davis requested a review from jvillafanez May 18, 2023 09:42
@phil-davis phil-davis merged commit 3cde0d3 into master May 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the symfony-command-execute-int branch May 18, 2023 10:19
@jnweiger jnweiger mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @jvillafanez