Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need clarification on getMusiFolders request #1108

Closed
hoffrichterm opened this issue Nov 20, 2023 · 2 comments
Closed

Need clarification on getMusiFolders request #1108

hoffrichterm opened this issue Nov 20, 2023 · 2 comments
Labels

Comments

@hoffrichterm
Copy link

hoffrichterm commented Nov 20, 2023

Hello everyone,

when looking at the subsonic 1.16.1 xsd (http://www.subsonic.org/pages/inc/api/schema/subsonic-rest-api-1.16.1.xsd) the response of the GetMusicFolders endpoint is a element with child elements. The id attributes of the child elements has to be numeric (Integer). Nextcloud Music is returning a response like this:

<?xml version="1.0" encoding="UTF-8"?>
<subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.16.1">
  <musicFolders>
    <musicFolder id="artists" name="Künstler"/>
    <musicFolder id="folders" name="Folders"/>
  </musicFolders>
</subsonic-response>

The endpoint URL is:
/index.php/apps/music/subsonic/rest/getMusicFolders?u=username&p=&v=1.16.1&c=webplayer

Maybe there are some hardcoded values or I have missed some documentation. Can you help me?

Thanks in advance
Marc

@paulijar
Copy link
Collaborator

paulijar commented Nov 21, 2023

There's a small deviation here between the API specification and the API implementation in the Music app. I originally didn't look carefully enough and didn't notice that the <musicFolder> elements have the type of id specified as int while every other element type in the API specify the id as string. I noticed it at some point later, but didn't care to fix it as this didn't seem to cause problems with any of the clients I have tested.

@paulijar paulijar added the Bug label Dec 22, 2023
paulijar added a commit that referenced this issue Jan 13, 2024
…e spec

The XML schema in the API specification defines the IDs of the "music
folders" as integers while all the other IDs in the API are string-typed.

refs #1108
@paulijar
Copy link
Collaborator

The newly released Music v1.10.0 now uses numeric id values for the <musicFolder> elements to conform the schema from the API spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants