Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsonic API call getLicense() returns 'never', which is invalid according to spec #759

Closed
jheyens opened this issue May 16, 2020 · 2 comments

Comments

@jheyens
Copy link

jheyens commented May 16, 2020

Subsonic API call getLicense() returns 'never' in field 'date', but, according to the API specification 'date' must be of type 'xs:dateTime', for which 'never' is not a valid value. Also, it does not matter that the 'date' field is optional.
A client implementing the spec may fail to parse this (which, incidentally, UltraSonic does)

I think since we cannot specify a reasonable value here, no value should be set at all. If you think this causes issues with existing (non-conforming-) clients, I'ld suggest something like $today+5 years, so we'll only see issues regarding this starting with 2033 :-)

@paulijar
Copy link
Collaborator

Thanks for the report. This API endpoint has been like this since my first draft of supporting the Subsonic API, and I suspect that none of the tested clients has ever used this method :D. At least I haven't seen the license information visible on any UI. I shall remove the optional fields from the response.

paulijar added a commit that referenced this issue May 16, 2020
The `licenseExpires` field did not conform to the Subsonic API specificaiton
as it is supposed to be a dateTime value.

refs #759
@paulijar
Copy link
Collaborator

This fix has now been released in the Music app v0.14.1. UltraSonic 2.7.0 seems to work fine now with the Music app. Thanks again @jheyens for your reports, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants