Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lyrics line formatting #780

Closed
britzke opened this issue Aug 1, 2020 · 5 comments
Closed

Lyrics line formatting #780

britzke opened this issue Aug 1, 2020 · 5 comments

Comments

@britzke
Copy link

britzke commented Aug 1, 2020

I have imported a mp3 file with included lyrics, which has been added in iTunes. Alle the line ends seem to be gone. This may Be an html formatting issue, when rendering lyrics out off the mp3 file itself.
@britzke
Copy link
Author

britzke commented Aug 1, 2020

Sorry, it should be "Lyrics line formatting" in the headline.

@paulijar paulijar changed the title Lyrics lin formatting Lyrics line formatting Aug 1, 2020
@paulijar
Copy link
Collaborator

paulijar commented Aug 1, 2020

Thanks for the report. Could you share one such file with me? You can find my email address from my profile. Which browser are you using?

@britzke
Copy link
Author

britzke commented Aug 1, 2020

I verified the issue with Safari, Firefox (OS X) and Edge (OS X, Beta) in their newest version.

@paulijar
Copy link
Collaborator

paulijar commented Aug 1, 2020

Your file seems to use "CR only" style for line breaks. This is kind of weird, because no modern systems should use this style. It used to be used on the classic Mac OS, but after OSX, also Mac should be using "LF only" style like the other Unix-based systems.

The web standards do not support this kind of line breaks, so this is why it gets rendered incorrectly. I shall see, if I could convert such lyrics automatically to more compliant format.

paulijar added a commit that referenced this issue Aug 2, 2020
@paulijar
Fix rendering of lyrics and other track details with "CR only" new lines
df6dc7a 
The "CR only" new line style shouldn't be used on any modern systems,
but apparently, files got from iTunes may use this style for the
embedded lyrics. Meanwhile, the web standards do not support this
style. Hence, lyrics with "CR only" new lines were rendered on web
browsers as if they had no line breaks at all.

Now all the new lines of the track details are normalized to the "LF
only" style already on the back-end. This is applied also to the lyrics
provided via the Subsonic API, as it was tested that at least Subsonic
Music Streamer and DSub can't handle the "CR only" style, either.

refs #780
@paulijar
Copy link
Collaborator

paulijar commented Aug 2, 2020

The Music v0.16.0 was just released, including also a fix for this issue.

@paulijar paulijar closed this as completed Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@britzke @paulijar