Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music app broken in ownCloud #792

Closed
thoja21 opened this issue Oct 19, 2020 · 5 comments
Closed

Music app broken in ownCloud #792

thoja21 opened this issue Oct 19, 2020 · 5 comments

Comments

@thoja21
Copy link

thoja21 commented Oct 19, 2020

Just updated the Music app via the market in ownCloud 10.5.0 and the app is now broken:

Screenshot 2020-10-19 at 4 43 02 pm

Owncloud: 10.5.0
Music app: 0.17.0
Server: Ubuntu 18.04 LTS
PHP: 7.2.24
Apache2: 2.4.29

No errors in apache logs, ownCloud, browser console. Uninstalling the app and re-installing it via the Market doesn't fix anything. Not sure what else to try.

@thoja21
Copy link
Author

thoja21 commented Oct 19, 2020

Running a check using occ app:check-code music reports the app as not compliant, however the errors/warnings don't look to be the cause of this:

output.txt

Checking the integrity of the app reports no issues (running: occ integrity:check-app music)

@thoja21
Copy link
Author

thoja21 commented Oct 19, 2020

Just installed a brand new instance of Owncloud 10.5.0 on a VM running the same versions fo Apache, PHP & Ubuntu and added the music app. Same issue occurs on a new install. No errors in the logs. The previous version of the Music app (0.16.0) works fine.

@thoja21 thoja21 changed the title Music app broken after update Music app broken Oct 19, 2020
@thoja21 thoja21 changed the title Music app broken Music app broken in ownCloud Oct 19, 2020
@paulijar
Copy link
Collaborator

Thanks for the report. I hadn't noticed this during the development, but now I could reproduce the error (on ownCloud 10.4) when I removed the test version of the Music app and installed it via the Market. After quite a bit of trial and error, I found out that ownCloud actually requires that the application has folders css and js on its root level. The Music app no longer uses these folders in the version 0.17.0, because with the webpack, it's more natural to store the release versions of both .js and .css files in the dist folder. But those folders still need to be there, even if they are empty.

As a quick fix, you could create those folders yourself:

cd path_to_your_owncloud_installation
cd apps-external/music
sudo mkdir css
sudo mkdir js

I'll also try to publish a new package to the Market very soon.

This problem is specific for ownCloud and does not affect any of the supported versions of Nextcloud.

@thoja21
Copy link
Author

thoja21 commented Oct 19, 2020

Thanks for the report. I hadn't noticed this during the development, but now I could reproduce the error (on ownCloud 10.4) when I removed the test version of the Music app and installed it via the Market. After quite a bit of trial and error, I found out that ownCloud actually requires that the application has folders css and js on its root level. The Music app no longer uses these folders in the version 0.17.0, because with the webpack, it's more natural to store the release versions of both .js and .css files in the dist folder. But those folders still need to be there, even if they are empty.

As a quick fix, you could create those folders yourself:

cd path_to_your_owncloud_installation
cd apps-external/music
sudo mkdir css
sudo mkdir js

I'll also try to publish a new package to the Market very soon.

This problem is specific for ownCloud and does not affect any of the supported versions of Nextcloud.

Great thanks for looking into that so quickly. I can confirm creating those folders sorts this for me. It's a shame nothing was logged in ownCloud for this, or anywhere at all.

@thoja21 thoja21 closed this as completed Oct 19, 2020
paulijar added a commit to paulijar/music that referenced this issue Oct 19, 2020
…er on ownCloud

For some reason, ownCloud (all supported versions) requires that the
app must have `css` and `js` folders in its root, even if they are
empty. If the folders are not there, the .css and .js files will not be
loaded from the `dist` folder, and the web UI cannot be used. Nextcloud
has no such issue.

The .gitattributes was now changed so that only the contents of those
folders are excluded from the release, but the folders themselves are
included.

refs owncloud#792
@paulijar
Copy link
Collaborator

Now there is also release v0.17.1 available which adds those two empty folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants