Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to redirect the browser if the notification says so. #218

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jvillafanez
Copy link
Member

The action must return an OCS response with a "redirectTo" key in
ocs.data, as well as mark in the action that it wants a redirection,
otherwise the redirection won't happen

Partially requires owncloud/core#32212 (the feature requires it but the app won't break if the core's PR is not there, just the feature won't work)

Fixes #212 along with the core's PR

The action must return an OCS response with a "redirectTo" key in
ocs.data, as well as mark in the action that it wants a redirection,
otherwise the redirection won't happen
@jvillafanez jvillafanez added this to the development milestone Aug 1, 2018
@jvillafanez jvillafanez self-assigned this Aug 1, 2018
@codecov-io
Copy link

codecov-io commented Aug 1, 2018

Codecov Report

Merging #218 into master will decrease coverage by 0.41%.
The diff coverage is 62.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #218      +/-   ##
============================================
- Coverage     89.55%   89.13%   -0.42%     
- Complexity      134      138       +4     
============================================
  Files            18       18              
  Lines           536      543       +7     
============================================
+ Hits            480      484       +4     
- Misses           56       59       +3
Flag Coverage Δ Complexity Δ
#phpunit 89.13% <62.5%> (-0.42%) 138 <0> (+4)
Impacted Files Coverage Δ Complexity Δ
lib/Handler.php 97.88% <60%> (-1.39%) 35 <0> (+3)
lib/Controller/EndpointController.php 93.05% <66.66%> (-1.15%) 18 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d3fa7f...6dc820c. Read the comment docs.

@PVince81 PVince81 modified the milestones: development, backlog Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants