Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

[tests-only] tests for account management permission checks #112

Merged
merged 9 commits into from
Sep 4, 2020

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Sep 4, 2020

Simple unit tests that don't care about the internals of the handler functions in pkg/service/v0/accounts.go, but only check if permission checks do what they are supposed to do.

Please note, that some of the permission checks will need to be changed when #111 is merged. There are TODO comments in the tests to explain what we will need to do.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine 👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann kulmann merged commit bf5bb9a into master Sep 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the permission-check-tests branch September 4, 2020 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants