-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add configs for web embed mode #421
Conversation
33f538f
to
3761149
Compare
@JammingBen |
As far as I understood this PR only gives the ability to set this config, but it will default to empty (=not being set). I don't know much about helm charts though, maybe some of our experts can verify this? If my assumption is correct it means Web will run in normal mode. The embed mode can then always be activated via the query param |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave it a try after updating to oCIS 5.0.0-alpha.2 (because I heard on a different channel, that this version is needed).
When setting services.web.config.mode
to embed
, the regular oC Web that you can reach on whatever you have set in externalDomain
will be replaced by the embeddable, stripped down oC Web. It looks like this:
In order to proceed with this PR we need to answer:
- should the chart always ship a full oC Web on the
externalDomain
? (I think it wouldn't make much sense to not ship a full oC Web!? Reasons welcome why it makes sense to only ship oC Web embed) - there is a way to use oC Web embed
When it comes to the usage of oC Web embed, I have some questions:
-
https://owncloud.dev/clients/web/embed-mode/ is providing an example how to integrate oC Web embed:
<iframe src="<web-url>?mode=embed"></iframe>
.
Does that mean I can integrate a oC Web, that doesn't have theWEB_OPTION_MODE
option set toembed
? This is also what I got fromThe embed mode can then always be activated via the query param mode=embed (and optionally embed-target=location).
Also appending
?mode=embed
results in a embed view in my tests. Maybe the question is: will this be supported until depreciated? -
The oC Web embed seems to use /config.json as configuration. Is there documentation about whether a integrating application can overwrite some settings like e.g.
tokenStorageLocal
or providing access tokens instead of a OIDC login flow done by oC Web embed? Because if the config.json is the only mean of configuration, we might have a conflict between oC Web and oC Web embed or even multiple oC Web embed use cases (that can be solved by deployment in some cases).
YES please always ship Web. |
Yes, you can always enable embed mode via the query param
I don't quite unterstand the question, why would we deprecate it? Both ways to enable the embed modes are valid, just the use cases may differ.
The token overwrite has not been implemented yet. We need the deployed instance for this so we can determine how exactly the integration looks like and how we need to implement it Web. |
Pushed again because the structure of the config changed a bit with owncloud/ocis#7766. Edit: also bumped oCIS to |
888c6eb
to
3c34ffa
Compare
Description
Adds 3 new configs for the Web embed mode that were recently added to oCIS (see owncloud/ocis#7670 and owncloud/ocis#7766):
embed.enabled
Defines if embed mode is enabled.embed.target
Defines how Web is being integrated when running in embed mode.embed.messagesOrigin
Defines a URL under which Web can be integrated via iFrame.Types of changes