Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

[UX] Improve client identifiers for end users #62

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Conversation

michaelstingl
Copy link
Contributor

Client names are end-user facing, so I'd propose to make them easier to understand for the end user:

web-bad web-good
Web login 👎 Web login 👍
desktop-bad desktop-good
Desktop login via default browser 👎 Desktop login via default browser 👍
ios-bad ios-good
iOS login via ASWebAuthenticationSession 👎 iOS login via ASWebAuthenticationSession 👍

@michaelstingl michaelstingl requested review from IljaN and micbar April 3, 2020 21:24
@update-docs
Copy link

update-docs bot commented Apr 3, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar
Copy link
Contributor

micbar commented Apr 3, 2020

Cool!

LGTM

@micbar micbar merged commit 957dd45 into master Apr 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the config/identifier-ux branch April 3, 2020 21:49
micbar added a commit that referenced this pull request Apr 14, 2020
@micbar micbar mentioned this pull request Apr 14, 2020
micbar added a commit that referenced this pull request Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants