This repository has been archived by the owner on Apr 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Converted back to a draft, because we need to enable the accounts and settings ui by default now. Will bring that in a separate PR. |
Needs a rebase after #80 got merged |
Just to be extra sure.
kulmann
force-pushed
the
release-0.12.0
branch
from
August 20, 2020 07:58
a06c8ee
to
85a1a6f
Compare
Rebased after #80 got merged. Now ready for review. |
PVince81
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ownclouders
pushed a commit
that referenced
this pull request
Aug 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update phoenix assets to 0.15.0
I also added the
clean
step to the release instructions for ocis-phoenix, because I had a message from fileb0x, telling me that switching from 0.14.0 to 0.15.0 didn't cause any changes in the generated assets. Runningmake clean generate
instead of justmake generate
caused the assets to be downloaded properly.