Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests to set expiration date when creating shares and links #111

Merged
merged 19 commits into from
Dec 8, 2023

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Dec 4, 2023

This PR adds test to set the expiration date during creation of shares and links.
The tests revealed some issues that have been fixed:

  • makes all date variables immutable, so that the passed in objects are not changed
  • delete the timezone conversion, its not needed
  • set the link type as object and not string

@individual-it individual-it changed the title tests to set/updete expiration date of created shares and links tests to set expiration date when creating shares and links Dec 5, 2023
@individual-it individual-it marked this pull request as ready for review December 5, 2023 11:21
@individual-it individual-it self-assigned this Dec 5, 2023
@@ -1,3 +1,3 @@
# The version of OCIS to use in pipelines that test against OCIS
OCIS_COMMITID=eed474bec8b77b98a789b4d588c34ca0c9db2ea7
OCIS_COMMITID=48fd95aec7131bcbafa9430c2e791ea1ca55954e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OCIS_COMMITID=48fd95aec7131bcbafa9430c2e791ea1ca55954e
OCIS_COMMITID=d5598188ca3cc45f104f2a192d8fdd556aa86d3d

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgraded!

Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.6% 70.6% Coverage
0.0% 0.0% Duplication

@individual-it individual-it merged commit 5840234 into main Dec 8, 2023
3 checks passed
@individual-it individual-it deleted the testExpiration branch December 8, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants