restrict invite requests to a single receiver #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
individual-it
requested review from
amrita-shrestha,
nirajacharya2,
phil-davis and
S-Panta
|
phil-davis
approved these changes
Dec 22, 2023
| @@ -76,17 +77,19 @@ public function testDeleteIndividualShare(): void | |||
| public function testDeleteGroupShare(): void | |||
| { | |||
| $philosophyHatersGroup = $this->ocis->createGroup( | |||
| 'philosophyhaters', | |||
| 'philosophy-haters', | |||
There was a problem hiding this comment.
Suggested change
| 'philosophy-haters', | |
| 'philosophyhaters', |
We removed these - yesterday.
| $shares = $this->ocis->getSharedByMe(); | ||
| foreach ($shares as $share) { | ||
| $this->assertInstanceOf(ShareCreated::class, $share); | ||
| if ($share->getReceiver()->getDisplayName() === 'philosophyhaters') { | ||
| if ($share->getReceiver()->getDisplayName() === 'philosophy-haters') { |
There was a problem hiding this comment.
Suggested change
| if ($share->getReceiver()->getDisplayName() === 'philosophy-haters') { | |
| if ($share->getReceiver()->getDisplayName() === 'philosophyhaters') { |
We removed these - yesterday.
ownclouders
pushed a commit
that referenced
this pull request
Dec 22, 2023
restrict invite requests to a single receiver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #138
oCIS will allow a maximum of one invite at a time after owncloud/ocis#8019
We can make the change here already now