integration tests for the invite function #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@individual-it this PR branch needs to be rebased. |
individual-it
force-pushed
the
inviteIntegrationTests
branch
from
0be5138 to
81a085b
Compare
Closed
individual-it
force-pushed
the
inviteIntegrationTests
branch
from
81a085b to
1e2a226
Compare
9 tasks
individual-it
force-pushed
the
inviteIntegrationTests
branch
from
e77de3c to
b039fea
Compare
individual-it
requested review from
amrita-shrestha,
S-Panta,
nirajacharya2 and
phil-davis
and removed request for
amrita-shrestha
Comment on lines
+133
to
+134
| $this->resourceToShare->invite([$this->einstein], $this->viewerRole); | ||
| $this->resourceToShare->invite([$this->einstein], $this->viewerRole); |
There was a problem hiding this comment.
how about using anotherRole for second invite
Suggested change
| $this->resourceToShare->invite([$this->einstein], $this->viewerRole); | |
| $this->resourceToShare->invite([$this->einstein], $this->viewerRole); | |
| $this->resourceToShare->invite([$this->einstein], $this->viewerRole); | |
| $this->resourceToShare->invite([$this->einstein], $this->anotherRole); |
| $this->assertSame($this->resourceToShare->getName(), $receivedShares[0]->getName()); | ||
| } | ||
|
|
||
| public function testInviteGroupAndUserOfTheGroup(): void |
There was a problem hiding this comment.
testInviteMultipleGroupWithCommonUser can be added too
|
I've added two more tests. Generally we have to find the right balance of testing here, we want to test all the code of the SDK including all edge cases we can think of, but on the other hand we don't need to test ocis in our tests. Testing if the API of ocis behaves correctly is part of the tests in ocis |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some first tests for the invite function of resources.
This depends on owncloud/libre-graph-api#147 or resolution of the problem in ocis