This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
fix serving static issues #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
fix/static-assets
branch
from
75de9e5 to
25785a9
Compare
tboerger
reviewed
Dec 13, 2019
tboerger
approved these changes
Dec 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocis-hello uses
"/"as root. adding another/causes the static middleware to always fail stripping that prefix. all requests will return 404.setting root to
""in the ocis-hello flag does not work because the chi dies screaming that routes need to start with a/.path.Clean(root+"/")would yield""for root="/"so I think this is the correct fix. unless we want to safeguard against an admin trying to use .. in the assets path, which should be permitted IMO.