This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Make TLS-Certificate configurable #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
IljaN
force-pushed
the
configurable_tls_cert
branch
2 times, most recently
from
6b58e42 to
c8a9f21
Compare
refs
approved these changes
Mar 24, 2020
| func publicKey(priv interface{}) interface{} { | ||
| switch k := priv.(type) { | ||
| case *rsa.PrivateKey: | ||
| return &k.PublicKey |
Currently the proxy generates certificates on every start for dev purposes. This commit adds an option to make this behaviour configurable. This also removes the dependency on konnectd`s crypto code and copies it instead, as this library is a first version which is not meant for usage by other services. A proper cert-generation lib should be added to ocis-pkg instead. Then this code can be refactored to use it.
IljaN
force-pushed
the
configurable_tls_cert
branch
from
c8a9f21 to
6583f7c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the proxy generates certificates on every start for dev purposes. This commit adds an option to make this behavior configurable.
This also removes the dependency on konnectd`s crypto code and copies it instead, as the library is a hacky prototype version which is not meant for usage by other services.
A proper cert-generation lib should be added to ocis-pkg instead. Then this code can be refactored to use it