Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

Retrieve Account UUID From User Claims #36

Merged
merged 15 commits into from
May 22, 2020
Merged

Conversation

refs
Copy link
Member

@refs refs commented Apr 30, 2020

For more context: https://owncloud.github.io/ocis/request-flow/

OIDC Middleware can make use of uuidFromClaims to trade claims.Email for an account's UUID. For this, a general purpose cache was added that caches on a per-request basis, meaning whenever the request parameters match a set of keys, the cached value is returned, saving a round trip to the accounts service that otherwise would happen in every single request.

Preconditions

  • proxy config requires an OIDC configuration.

@update-docs
Copy link

update-docs bot commented Apr 30, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@refs refs requested a review from kulmann April 30, 2020 11:55
pkg/server/http/server.go Outdated Show resolved Hide resolved
@refs refs self-assigned this May 4, 2020
@ownclouders
Copy link

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- pkg/middleware/account_uuid.go  9
- pkg/cache/cache.go  4
- pkg/cache/cache_test.go  6
- pkg/cache/option.go  2
         

See the complete overview on Codacy

@refs refs merged commit d7eab50 into master May 22, 2020
@refs refs deleted the feature/accounts-uuid-middleware branch May 22, 2020 11:01
@butonic butonic mentioned this pull request Jun 8, 2020
19 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants