Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Test to prove that 67 works #170

Closed
wants to merge 3 commits into from
Closed

Test to prove that 67 works #170

wants to merge 3 commits into from

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented May 5, 2020

To demonstrate and debug #67

Matches core PR owncloud/core#37344

@update-docs
Copy link

update-docs bot commented May 5, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@individual-it
Copy link
Member

same issue I fear
image

@PVince81
Copy link
Contributor Author

PVince81 commented May 5, 2020

next up ideas to try:

  • running drone locally with that test
  • bringing local env as close as possible to the one from Drone

@PVince81
Copy link
Contributor Author

PVince81 commented May 5, 2020

differences in env compared to https://owncloud.github.io/extensions/ocis_reva/testing :

  • on Drone, we're missing:
    • REVA_USERS_DRIVER=ldap
    • REVA_LDAP_USERFILTER
    • REVA_LDAP_GROUPFILTER
    • REVA_LDAP_SCHEMA_UID
    • REVA_LDAP_SCHEMA_MAIL
    • REVA_LDAP_SCHEMA_CN
  • in the documentation, some env vars are not set that do exist on CI, probably we are relying on defaults:
    • 'REVA_STORAGE_HOME_DATA_TEMP_FOLDER': '/srv/app/tmp/',
    • 'REVA_STORAGE_OWNCLOUD_DATADIR': '/srv/app/tmp/reva/data',
    • 'REVA_STORAGE_OC_DATA_TEMP_FOLDER': '/srv/app/tmp/',
    • 'REVA_STORAGE_OWNCLOUD_REDIS_ADDR': 'redis:6379',
    • 'REVA_SHARING_USER_JSON_FILE': '/srv/app/tmp/reva/shares.json'
  • the list of started reva services is identical

so far I don't see why this would make a difference

@PVince81
Copy link
Contributor Author

PVince81 commented May 5, 2020

I've modified the config now to only run that one issue for quicker results.

@PVince81
Copy link
Contributor Author

PVince81 commented May 5, 2020

likely an env issue, maybe "/etc/mime.types" is minimal or does not exist: https://golang.org/pkg/mime/#TypeByExtension

see #67 (comment) for context

still, I think it might make sense to add an additional test to read the mime type of a text file from Webdav, it will likely highlight this env issue further even after the reva fix @individual-it

@PVince81
Copy link
Contributor Author

PVince81 commented May 5, 2020

added commit to print out mime types file, we'll see

@PVince81
Copy link
Contributor Author

PVince81 commented May 5, 2020

hah...

cat: can't open '/etc/mime.types': No such file or directory

so this is the explanation why it failed on Drone but passed locally, as we locally have that file @individual-it ^

@PVince81
Copy link
Contributor Author

PVince81 commented May 7, 2020

rebased so it runs with the actual fixes

@PVince81
Copy link
Contributor Author

PVince81 commented May 7, 2020

rebased again for further changes

the build setup failed anyway

@PVince81 PVince81 marked this pull request as ready for review May 7, 2020 10:16
@PVince81
Copy link
Contributor Author

PVince81 commented May 7, 2020

some weird shit happening here:

image

anyway, the code PR was merged already.
if by any bad luck the size issue is still there on master, let me know...

@PVince81 PVince81 closed this May 7, 2020
@PVince81 PVince81 deleted the test-67 branch May 7, 2020 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants